feat: range requests for wheel #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdejager
approved these changes
Nov 2, 2023
Comment on lines
+158
to
+159
| // Get the size of the entry plus the header + size of the filename. We should also actually | ||
| // include bytes for the extra fields but we don't have that information. |
There was a problem hiding this comment.
What happens now that we don't know this?
There was a problem hiding this comment.
We cross our fingers that the entry doesnt include extra fields. But because we also align to the bufreader size most likely we dont need to do another range request anyway. In the worst case another range request is performed.
Co-authored-by: Tim de Jager <[email protected]>
tdejager
reviewed
Nov 2, 2023
| // Make sure we have the back part of the stream. | ||
| // Because the zip index is at the back | ||
| stream | ||
| .prefetch(stream.len().saturating_sub(16384)..stream.len()) |
There was a problem hiding this comment.
Ah good question! Thats my best guess at the size of the central archive directory (the index). Sometimes its more, which then causes another range requests but most of the times it less.
tdejager
reviewed
Nov 2, 2023
Co-authored-by: Tim de Jager <[email protected]>
|
Ouch we have a conflict |
|
Which is now fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation to use range requests to read metadata from wheels. This speeds up metadata fetching for large wheels significantly.