feat: add support for stree installing #202
Conversation
| return built; | ||
| } else { | ||
| miette::bail!("cannot build wheel without a wheel builder"); | ||
| } | ||
| } | ||
|
|
||
| // Try to build the wheel for this SDist if possible |
There was a problem hiding this comment.
I might be missing something but one of the original problems, was that if a wheel or sdists was referenced by file, this call below will fail.
There was a problem hiding this comment.
Actually, just tested this and it still does:
$ cargo r "miniblack @ file:///Users/tdejager/development/prefix/rattler_installs_packages/test-data/wheels/miniblack-23.1.0-py3-none-any.whl" --install-into /tmp/bla2
# errors with:
installing: miniblack - 23.1.0
2024-02-08T08:45:22.764833Z INFO rattler_installs_packages::index::http: executing request url=file:///Users/tdejager/development/prefix/rattler_installs_packages/test-data/wheels/miniblack-23.1.0-py3-none-any.whl cache_mode=Default
× Request error: builder error for url (file:///Users/tdejager/development/prefix/rattler_installs_packages/test-data/wheels/miniblack-23.1.0-py3-none-any.whl): URL scheme is not allowed
├─▶ builder error for url (file:///Users/tdejager/development/prefix/rattler_installs_packages/test-data/wheels/miniblack-23.1.0-py3-none-any.whl): URL scheme is not allowed
╰─▶ URL scheme is not allowedThere was a problem hiding this comment.
yes that's true - I've missed this and spotted during direct_url.json development.
Will fix it and add a test
|
I've added is_direct_url into ArtifactInfo, so I could differentiate what kind of artifact it is without adding these field into SdistFilename and WheelFileName. Let me know what do you think @tdejager |
Yes, I was also thinking about that, let's try that design for now :) |
Co-authored-by: Tim de Jager <[email protected]>
closes: #201