feat: special case true / false boolean values in variant config #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable to me 👍🏻 I'm looking forward to a CEP for the variant file 😄 |
|
Hmm, this implementation is actually flawed because you can't opt out of the integer / bool thing by using So maybe we should do the proper thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pavelzw this should fix #691, although it doesn't attack the problem at the parsing level but later on, when we insert the values into minijinja.
I think I prefer this behavior although it might not be completely obvious.
We could also make it work at parsing time but we would need to change the type of the variant config to allow for either a string or a boolean value. I was too lazy to do that right now :)
We should note that if we change the type later (so that variatn config is a map of bool | string), then hashes would also change, if we don't continue to normalize them to strings.