Python recipe render improvements #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
force-pushed
the
py-render-improvement
branch
from
270838d to
c9ac681
Compare
wolfv
changed the title
baszalmstra
reviewed
Jan 7, 2025
| from itertools import product | ||
|
|
||
|
|
||
| def variant_combinations(data: dict[str, str | list[str]]) -> list[dict[str, str]]: |
There was a problem hiding this comment.
Could definitely use a function docstring and explain what the inputs and outputs are.
|
|
||
|
|
||
| # Custom constructor for loading floats as strings | ||
| def float_as_string_constructor(loader, node) -> str: # noqa: ANN001 | ||
| return loader.construct_scalar(node) | ||
|
|
||
|
|
||
| def convert_to_plain_types(data: Any) -> Any: # noqa: ANN401 |
There was a problem hiding this comment.
Can you add a docstring? What is a plain type?
| override_version: str | None = None, | ||
| ) -> set[Source]: | ||
| """ | ||
| This function should render _all_ URL sources with the |
| from itertools import product | ||
|
|
||
|
|
||
| def variant_combinations(data: dict[str, str | list[str]]) -> list[dict[str, str]]: |
There was a problem hiding this comment.
Does it make sense to add a few test cases specifically for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renders the data more properly in order to extract all the sources. The plan is:
Ideally, this will be implemented in rattler build as a command such as
rattler-build bump-version ./recipe -m ./variant-config/*.yaml- but for now I am prototyping this here to get it into the bot.