feat: metadata will render recipe with context #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichmor
commented
Aug 2, 2024
baszalmstra
reviewed
Aug 2, 2024
| name = _get_recipe_metadata(self.meta, "name") | ||
|
|
||
| if not name: | ||
| sys.exit(f"Error: package/name missing in: {self.meta_path!r}") |
There was a problem hiding this comment.
Please just raise and let the user determine whether or not the application should exit or not!
There was a problem hiding this comment.
This wasn't my implementation - I tried to reuse the same approach as conda_build does - so I decided to not move from sys.exit. Let me know if you think that it's worth to change it
| version = _get_recipe_metadata(self.meta, "version") | ||
|
|
||
| if not version: | ||
| sys.exit(f"Error: package/version missing in: {self.meta_path!r}") |
it's the same API - I just override it because we extract them from recipe/package depending on |
baszalmstra
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to give
Metadataability to render recipe using context values.It will be used by conda-smithy to ask metadata.name() and metadata.version()