fix: don't modify manifest on failing change #2756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are the intermediate saves needed? This implementation seems quite
hacky.
…On Fri, 20 Dec 2024 at 17:17, Ruben Arts ***@***.***> wrote:
Fixes: #2516 <#2516>
We still need to figure out if we could get rid of the intermediary saves
but this will help the users with reverting the changes if it fails.
------------------------------
You can view, comment on, or merge this pull request online at:
#2756
Commit Summary
- bf64873
<bf64873>
fix: undo changes to manifest if it fails to solve and install on add or
upgrade
File Changes
(4 files <https://github.com/prefix-dev/pixi/pull/2756/files>)
- *M* src/cli/add.rs
<https://github.com/prefix-dev/pixi/pull/2756/files#diff-52e88acc3ab9bc36d40fb6a637c96b8b82a20b9b9d8e5f64adb5990952773c84>
(17)
- *M* src/cli/upgrade.rs
<https://github.com/prefix-dev/pixi/pull/2756/files#diff-63422bd7313d222b0647e871e2379a5e0225f0eeb308e8964a934823f2273d46>
(16)
- *M* src/project/mod.rs
<https://github.com/prefix-dev/pixi/pull/2756/files#diff-78c425ecb327c26438b6d71f1aa594b30d4903afa5ddc55ada2dbc31c8ec9d22>
(4)
- *M* tests/integration_python/test_main_cli.py
<https://github.com/prefix-dev/pixi/pull/2756/files#diff-172c65bd6d2ae80bc65af36f45fc42cf58d350955039462164406e72228e417a>
(18)
Patch Links:
- https://github.com/prefix-dev/pixi/pull/2756.patch
- https://github.com/prefix-dev/pixi/pull/2756.diff
—
Reply to this email directly, view it on GitHub
<#2756>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGDW733IO32KNKR5I7YRFT2GQ7KBAVCNFSM6AAAAABT7NTF7WVHI2DSMVQWIX3LMV43ASLTON2WKOZSG42TGMBUGM4TAMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@baszalmstra Because we need to update the dependencies directly in file to allow for correct solving of the PyPI environment when it is used as a |
2 tasks
|
This also doesn't work with interrupting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2516
We still need to figure out if we could get rid of the intermediary saves but this will help the users with reverting the changes if it fails.