Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add pytorch integration guide. #2711

Merged

Conversation

ruben-arts
Copy link
Contributor

@ruben-arts ruben-arts commented Dec 16, 2024

Initial write-up of the use of PyTorch with pixi.

Thanks to @anjos and @hadim for helping me with my previous attempt, this version is based on #2123

This adds 3 different ways of installing PyTorch to the documentation under Features.

Testing

We've added a test setup to test these examples, so all TOML information is part of actual TOML files and "snippeted" into the documentation. These TOML files are run in CI by installing them on all platforms that the examples are supported on. E.g. conda-forge doesn't support windows yet.

Because this test blown up the windows' runner, I took the liberty to also split the tests like we talked about. I'm not proud of doing it in this PR, but I rather don't merge failing CI

@ruben-arts ruben-arts requested a review from tdejager December 16, 2024 13:44
docs/features/pytorch.md Outdated Show resolved Hide resolved
docs/features/pytorch.md Outdated Show resolved Hide resolved
docs/features/pytorch.md Outdated Show resolved Hide resolved
docs/features/pytorch.md Show resolved Hide resolved
docs/features/pytorch.md Outdated Show resolved Hide resolved
docs/features/pytorch.md Outdated Show resolved Hide resolved
docs/features/pytorch.md Outdated Show resolved Hide resolved
docs/features/pytorch.md Outdated Show resolved Hide resolved
docs/features/pytorch.md Outdated Show resolved Hide resolved
@anjos
Copy link

anjos commented Dec 17, 2024

@ruben-arts: thanks for this work, I think it really clarifies compatibilities and offers concrete solutions to users of pixi! Excellent job!

@ruben-arts ruben-arts added the test:extra_slow Run the extra slow tests label Dec 17, 2024
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, up to you @ruben-arts if you want to apply it.

The testing looks good for now.

@ruben-arts and I agree that we want to move the "extra_slow" tests to their own workflow as a follow-up

tests/integration_python/common.py Outdated Show resolved Hide resolved
@ruben-arts ruben-arts enabled auto-merge (squash) December 19, 2024 14:28
@ruben-arts ruben-arts disabled auto-merge December 19, 2024 14:28
@ruben-arts ruben-arts merged commit c909168 into prefix-dev:main Dec 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:extra_slow Run the extra slow tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants