-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add matchspec caching #2637
Merged
tdejager
merged 12 commits into
prefix-dev:main
from
nichmor:feat/matchspec-for-cache-tool
Dec 9, 2024
Merged
feat: add matchspec caching #2637
tdejager
merged 12 commits into
prefix-dev:main
from
nichmor:feat/matchspec-for-cache-tool
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
reviewed
Dec 5, 2024
…xi into feat/matchspec-for-cache-tool
wolfv
reviewed
Dec 5, 2024
wolfv
reviewed
Dec 5, 2024
wolfv
reviewed
Dec 5, 2024
tdejager
reviewed
Dec 9, 2024
tdejager
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds ability to load already existing tool from the disk.
So if previously we installed
boltons==1.0.0
, and now we are requestingboltons *
, we will preload it.if we request
boltons >= 1.1.0
, we will install a new one.More details are inside the
Matches
trait : https://github.com/conda/rattler/blob/main/crates/rattler_conda_types/src/match_spec/mod.rs#L364it also add a new clean command for cache,
pixi clean cache --tool
to clean build tools envs.How to test it:
rattler/cache/cached-build-tool-envs-v0
if exist.pixi install -vvv
for rich_example. You will see in tracing::debugnot found any existing environment
message, and alsocached-build-tool-envs-v0
should now have a folder for installed tool.pixi install -vvv
. You will see nowreusing existing environment in
and no new folders should be incached-build-tool-envs-v0
.build-backend = { name = "pixi-build-python", version = "<0.1.0dev20241203154923" }
. This will make pixi to search for older pixi, that don't satisfisy already installed one.run
pixi install -vvv
and now you will seenot found any existing environment for
and a new folder for this new tool should be incached-build-tool-envs-v0
.