Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Enhance installation script with custom destination and update documentation #2606

Conversation

jjjermiah
Copy link
Contributor

@jjjermiah jjjermiah commented Dec 1, 2024

Found this script useful while working on features for other tooling, i use PIXI_HOME for my binaries so this feature helps write it to the same location.

  • also wanted to describe how to use it for other devs looking to contribute
  • Refactor the installation script to support specifying a custom destination for executables and add logging for better visibility.
  • Update CONTRIBUTING.md to include instructions for the new installation method.

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjjermiah!

I've adapted the behavior so that it defaults to $PIXI_HOME/bin if that env var is set

@Hofer-Julian Hofer-Julian merged commit 0b63796 into prefix-dev:main Dec 2, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants