Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trampoline without corresponding json breaking #2576

Merged

Conversation

Hofer-Julian
Copy link
Contributor

@Hofer-Julian Hofer-Julian commented Nov 27, 2024

Fixes #2537

  • Fix behaviour
  • Add test
  • Rename GlobalBin to GlobalExecutable
  • Add logging messages
  • Remove test_sync_clean_up_broken_exec -> we only clean up invalid trampoline-configuration pairs now

@Hofer-Julian Hofer-Julian requested a review from nichmor November 28, 2024 08:13
@Hofer-Julian Hofer-Julian marked this pull request as ready for review November 28, 2024 08:24
Copy link
Contributor

@nichmor nichmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Hofer-Julian Hofer-Julian merged commit 4e16fe0 into prefix-dev:main Nov 28, 2024
48 checks passed
@Hofer-Julian Hofer-Julian deleted the fix/trampoline-without-json branch November 28, 2024 09:25
jjjermiah pushed a commit to jjjermiah/pixi that referenced this pull request Nov 30, 2024
Fixes prefix-dev#2537

- Fix behaviour
- Add test
- Rename `GlobalBin` to `GlobalExecutable`
- Add logging messages
- Remove `test_sync_clean_up_broken_exec` -> we only clean up invalid
trampoline-configuration pairs now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pixi global can't deal with trampolines that don't have a corresponding `json
2 participants