Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reorder manifest discovery logic #2564

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

Hofer-Julian
Copy link
Contributor

@Hofer-Julian Hofer-Julian commented Nov 25, 2024

Fixes #2473

Now the manifest in your folder structure will take priority over the manifest set through the pixi shell activation. Instead of the other way around.

@Hofer-Julian Hofer-Julian marked this pull request as ready for review November 25, 2024 16:31
@ruben-arts
Copy link
Contributor

Do you have an idea how to best document this in the documentation?

@Hofer-Julian
Copy link
Contributor Author

Do you have an idea how to best document this in the documentation?

Somewhere here: https://pixi.sh/latest/features/advanced_tasks/

Will extend the docs

- Set manifest discovery
- Set order that first priority comes first
@Hofer-Julian Hofer-Julian changed the title fix: task discovery fix: manifest discovery Nov 26, 2024
@ruben-arts ruben-arts changed the title fix: manifest discovery fix: Reorder manifest discovery logic Nov 26, 2024
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Works like a charm!

@ruben-arts ruben-arts merged commit f77b02f into prefix-dev:main Nov 26, 2024
46 checks passed
jjjermiah pushed a commit to jjjermiah/pixi that referenced this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change task discovery behaviour with activated pixi environment
2 participants