Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add package specific dependencies and errors #2556

Merged

Conversation

baszalmstra
Copy link
Contributor

@baszalmstra baszalmstra commented Nov 24, 2024

Builds on #2544 .

This PR adds dependencies to either workspace or package targets based on the rest of the content of the manifest.

E.g.

[project]

[host-dependencies]

[dependencies]

Adds both the host-dependencies and the dependencies to the default target of the default feature of the workspace/project. But:

[workspace]
preview = ["pixi-build"]

[dependencies]

[package]

[host-dependencies]

Adds the host-dependencies to the default target of the package manifest instead.

I also added loads of corner error cases with helpful snippets and help messages to clarify what happens when enabling the preview feature (see the pushed snippets).

Build backends should read the package section of the manifest and disregard the workspace/project section. But thats for follow-up PRs to the backends.

@baszalmstra baszalmstra force-pushed the refactor/package_targets branch from 2e3952e to 157e924 Compare November 24, 2024 21:18
@baszalmstra baszalmstra force-pushed the refactor/package_targets branch from 157e924 to ec3489b Compare November 25, 2024 09:47
@baszalmstra baszalmstra enabled auto-merge (squash) November 25, 2024 12:38
@baszalmstra baszalmstra merged commit 4ef8398 into prefix-dev:feature/pixi-build Nov 25, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants