feat: add package specific dependencies and errors #2556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2544 .
This PR adds dependencies to either workspace or package targets based on the rest of the content of the manifest.
E.g.
Adds both the
host-dependencies
and thedependencies
to the default target of the default feature of the workspace/project. But:Adds the
host-dependencies
to the default target of the package manifest instead.I also added loads of corner error cases with helpful snippets and help messages to clarify what happens when enabling the preview feature (see the pushed snippets).
Build backends should read the package section of the manifest and disregard the workspace/project section. But thats for follow-up PRs to the backends.