feat: Add XDG_CONFIG_HOME/.config to search of pixi global manifest path
#2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
changed the title
XDG_CONFIG_HOME/.config to search of pixi global manifest pathXDG_CONFIG_HOME/.config to search of pixi global manifest path
hoxbro
force-pushed
the
config_global
branch
from
ccb44fa to
e1058ac
Compare
|
@hoxbro thanks for your contribution! I've extended your PR and fixed a few problems with it, docs are now present as well. Also tried to add tests, but had to give up on that. I simply couldn't find a way to set environment variables without influencing other tests. |
|
Hey I checked it out, but it will always try to write into the Please check if it exists first. |
Should be fixed now |
ruben-arts
approved these changes
Nov 27, 2024
Co-authored-by: Ruben Arts <[email protected]>
Co-authored-by: Ruben Arts <[email protected]>
jjjermiah
pushed a commit
to jjjermiah/pixi
that referenced
this pull request
Nov 30, 2024
…st path (prefix-dev#2547) Follow up on the question asked here: https://discord.com/channels/1082332781146800168/1307282213770891329 This will search `$XDG_CONFIG_HOME/pixi/pixi-global.toml`, then `~.config/pixi/pixi-global.toml`, and at last, the current location `$PIXI_HOME/manifests/pixi-global.toml`. The code could be better, so I would love feedback. TODO: - Need to add some tests (not entirely sure how easy this would be with being dependent on the filesystem) - Update the https://pixi.sh/latest/features/global_tools/#manifest-locations --------- Co-authored-by: Hofer-Julian <[email protected]> Co-authored-by: Julian Hofer <[email protected]> Co-authored-by: Ruben Arts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on the question asked here: https://discord.com/channels/1082332781146800168/1307282213770891329
This will search
$XDG_CONFIG_HOME/pixi/pixi-global.toml, then~.config/pixi/pixi-global.toml, and at last, the current location$PIXI_HOME/manifests/pixi-global.toml.The code could be better, so I would love feedback.
TODO: