Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow configuring pypi insecure host #2521

Merged
merged 21 commits into from
Dec 2, 2024
Merged

feat: allow configuring pypi insecure host #2521

merged 21 commits into from
Dec 2, 2024

Conversation

zen-xu
Copy link
Contributor

@zen-xu zen-xu commented Nov 20, 2024

close #1982

@zen-xu zen-xu changed the title feat: allow configuring insecure host feat: allow configuring pypi insecure host Nov 20, 2024
@ruben-arts
Copy link
Contributor

This looks good to me, @tdejager could you review this?

@ruben-arts ruben-arts requested a review from tdejager November 20, 2024 08:02
@tdejager
Copy link
Contributor

tdejager commented Nov 21, 2024 •
edited
Loading

Thanks @zen-xu for the PR! The Implementation looks fine, the question for me would be if we want uv_configuration as a dependency because then we can never publish this specific crate, otherwise we need to define the type and conversion ourselves. Personally, I'd be for that.
cc @ruben-arts @baszalmstra

tdejager
tdejager requested changes Nov 21, 2024
View reviewed changes
crates/pixi_config/Cargo.toml Outdated Show resolved Hide resolved
@zen-xu zen-xu requested a review from tdejager November 28, 2024 09:43
@zen-xu zen-xu mentioned this pull request Nov 29, 2024
Closed
2 tasks
@zen-xu zen-xu force-pushed the allow-insecure-host branch from ad3083c to f268886 Compare December 2, 2024 02:27
@zen-xu
Copy link
Contributor Author

zen-xu commented Dec 2, 2024

hi @tdejager, ready for review

tdejager
tdejager approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@tdejager tdejager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks great!

@ruben-arts ruben-arts enabled auto-merge (squash) December 2, 2024 08:01
@ruben-arts ruben-arts merged commit 51d9920 into prefix-dev:main Dec 2, 2024
43 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 2, 2024
Merged
@zen-xu zen-xu mentioned this pull request Dec 3, 2024
Merged
ruben-arts pushed a commit that referenced this pull request Dec 5, 2024
@zen-xu
fix: forgot to configure allow_insecure_host when resolve_pypi (#2622)
06dd411 
I'm sorry I missed this point in #2521 @_@
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruben-arts ruben-arts ruben-arts left review comments

@tdejager tdejager tdejager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid peer certificate with --tls-no-verify
3 participants
@zen-xu @ruben-arts @tdejager