Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --prepend option for pixi project channel add #2447

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

mrswastik-robot
Copy link
Contributor

trying to fix #2349

Example:

If the current pixi.toml has:

[project]
channels = ["conda-forge"]

After running pixi project channel add pytorch --prepend , the channels list will become:

[project]
channels = ["pytorch", "conda-forge"]

unit test regarding the above functionality is passing:
Screenshot from 2024-11-10 02-46-18

this is my first time trying to contribute to pixi, and I am not that good in Rust too, so any kind of help will be very much appreciated. I will be happy to make requested code changes for this PR.

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, could you add it to the cli documentation? (docs/reference/cli.md)

@mrswastik-robot
Copy link
Contributor Author

Thank you, could you add it to the cli documentation? (docs/reference/cli.md)

hii @ruben-arts , I have done it, can you have a look into it

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great nice work!

@ruben-arts ruben-arts merged commit 689cf9d into prefix-dev:main Nov 11, 2024
43 checks passed
@mrswastik-robot mrswastik-robot deleted the feature/cli-prepend branch November 11, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --prepend option for pixi project channel add
2 participants