Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /root/.pixi/bin to the PATH and associated test #64

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

hadim
Copy link
Contributor

@hadim hadim commented Dec 13, 2024

Fix #40

This is fragile since it won't work if the user is modified, but at least it will make pixi global binaries available "by default" without any additional tweaks.

@hadim
Copy link
Contributor Author

hadim commented Dec 13, 2024

@pavelzw what do you think about pre-installing git with pixi global install given #41 ?

@pavelzw
Copy link
Collaborator

pavelzw commented Dec 16, 2024

I think the size increase is too much when not all users benefit from it (git is only used in pypi dependencies and I personally still think that you should package everything as a conda package if possible).

❯ docker history pixi-docker-no-git
IMAGE          CREATED         CREATED BY                                      SIZE      COMMENT
9eb4291ea7ca   4 minutes ago   ENV PATH=/root/.pixi/bin:/usr/local/sbin:/us…   0B        buildkit.dockerfile.v0
<missing>      4 minutes ago   COPY --chown=root:root --chmod=0555 /pixi /u…   32.6MB    buildkit.dockerfile.v0
<missing>      2 weeks ago     # debian.sh --arch 'arm64' out/ 'bookworm' '…   97.2MB    debuerreotype 0.15
❯ docker history pixi-docker-git
IMAGE          CREATED              CREATED BY                                      SIZE      COMMENT
62947da63edb   About a minute ago   RUN /bin/sh -c pixi global install git && pi…   218MB     buildkit.dockerfile.v0
<missing>      About a minute ago   ENV PATH=/root/.pixi/bin:/usr/local/sbin:/us…   0B        buildkit.dockerfile.v0
<missing>      4 minutes ago        COPY --chown=root:root --chmod=0555 /pixi /u…   32.6MB    buildkit.dockerfile.v0
<missing>      2 weeks ago          # debian.sh --arch 'arm64' out/ 'bookworm' '…   97.2MB    debuerreotype 0.15

for reference: pixi-docker-git was created by adding RUN pixi global install git && pixi clean cache -y to the end of the dockerfile

If users need git, they can just global install it themselves (or do it via apt-get)

@pavelzw pavelzw merged commit d6e2b56 into prefix-dev:main Dec 16, 2024
24 checks passed
@pavelzw pavelzw added the enhancement New feature or request label Dec 16, 2024
@hadim hadim deleted the path branch December 16, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding /root/.pixi/bin to the path?
2 participants