Proper caching support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Nov 9, 2023
baszalmstra
approved these changes
Nov 10, 2023
|
Added docs and in the process remove the url parameter from the response methods. This means that for each subsequent request, we will use the url that the first response returned (e.g. if there were redirects we followed) |
|
thanks @konstin ! Looks very good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the
AsyncHttpRangeReaderconstructor into the initial request and the subsequent processing and requests to allow moving the initial request into a cache framework. The usage for this is explained in 06chaynes/http-cache#57 (comment), withwheel_metadata_from_remote_zipbeing effectively https://github.com/prefix-dev/rip/pull/66/files#diff-831fc4351ab4266447169dae09f756a01f8c308e024e6836ec91a585695eb992R112-R204 .The change requires the user to ensure they pass the correct response into
new_tail_response/new_head_response.Open questions: Which methods should be public, and which ones shouldn't be? Currently i just mad everything public.