Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade reqwest to v0.12.3 #12

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

charliermarsh
Copy link
Contributor

No description provided.

@charliermarsh charliermarsh changed the title Upgrade reqwest to v0.12.3 [chore] Upgrade reqwest to v0.12.3 Apr 10, 2024
@charliermarsh charliermarsh changed the title [chore] Upgrade reqwest to v0.12.3 chore: Upgrade reqwest to v0.12.3 Apr 10, 2024
@@ -31,25 +31,27 @@ impl StaticDirectoryServer {
// port is very important because it enables creating multiple instances at the same time.
// We need this to be able to run tests in parallel.
let addr = SocketAddr::new([127, 0, 0, 1].into(), 0);
let server = axum::Server::bind(&addr).serve(app.into_make_service());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

axum::Server was removed in 0.7.0. The changelog suggests using axum::serve: https://github.com/tokio-rs/axum/blob/main/axum/CHANGELOG.md#070-27-november-2023.

Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@baszalmstra baszalmstra merged commit 08f2a60 into prefix-dev:main Apr 10, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants