-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package configuration #4
base: main
Are you sure you want to change the base?
Conversation
default_value: Any | ||
allowed_values: Optional[Union[Tuple[Any, ...], List[Any]]] | ||
|
||
def _get_values(self, param: str) -> Tuple[Any, ...]: |
Check notice
Code scanning / CodeQL
Returning tuples with varying lengths Note
tuple of size 0
tuple of size 1
else: | ||
return (param_values,) | ||
|
||
def get_allowed_values(self) -> Tuple[Any, ...]: |
Check notice
Code scanning / CodeQL
Returning tuples with varying lengths Note
tuple of size 0
tuple of size 1
""" | ||
return self._get_values("allowed_values") | ||
|
||
def get_expected_type(self) -> Tuple[type, ...]: |
Check notice
Code scanning / CodeQL
Returning tuples with varying lengths Note
tuple of size 0
tuple of size 1
dh.set_config(do_something_else=True) | ||
|
||
with pytest.raises(TypeError): | ||
dh.set_config(True) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call Error test
function set_config
def test_set_config_invalid_keyword_argument(): | ||
"""Test set_config behavior when invalid keyword argument passed.""" | ||
with pytest.raises(TypeError): | ||
dh.set_config(do_something_else=True) |
Check failure
Code scanning / CodeQL
Wrong name for an argument in a call Error test
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
What should a reviewer concentrate their feedback on?
Any other comments?
PR checklist
For all contributions
the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions