Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

views: improve approval dialogue rendering #241

Merged
merged 8 commits into from
Nov 25, 2024
Merged

views: improve approval dialogue rendering #241

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ac920a0
use valueViewComponent from ui library
TalDerei Nov 22, 2024
0a8034a
manual css
TalDerei Nov 22, 2024
3715a16
refactor arrow for one-way swaps
TalDerei Nov 25, 2024
06b5630
revert accidental commit
TalDerei Nov 25, 2024
96270e0
truncate value component
TalDerei Nov 25, 2024
81e3ea4
background of approval and deny button layer
TalDerei Nov 25, 2024
7c22192
ignore site
TalDerei Nov 25, 2024
a450d91
address feedback
TalDerei Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/extension/src/routes/popup/approval/approve-deny.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ export const ApproveDeny = ({
</Button>
{ignore && (
<Button
className='w-[32%] py-2.5 text-sm hover:bg-destructive/90'
size='md'
className='w-1/2 py-3.5 text-base hover:bg-destructive/90'
size='lg'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix dimensions of site settings button

before

Screenshot 2024-11-24 at 9 48 10 PM

after

Screenshot 2024-11-24 at 9 51 31 PM

variant='secondary'
onClick={ignore}
>
Expand Down
Loading