Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

views: improve approval dialogue rendering #241

Merged
merged 8 commits into from
Nov 25, 2024
Merged

views: improve approval dialogue rendering #241

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ac920a0
use valueViewComponent from ui library
TalDerei Nov 22, 2024
0a8034a
manual css
TalDerei Nov 22, 2024
3715a16
refactor arrow for one-way swaps
TalDerei Nov 25, 2024
06b5630
revert accidental commit
TalDerei Nov 25, 2024
96270e0
truncate value component
TalDerei Nov 25, 2024
81e3ea4
background of approval and deny button layer
TalDerei Nov 25, 2024
7c22192
ignore site
TalDerei Nov 25, 2024
a450d91
address feedback
TalDerei Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions packages/ui/components/ui/tx/actions-views/output.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,19 @@
<ViewBox
label='Output'
visibleContent={
<div className='flex items-center justify-between gap-3'>
<ValueViewComponent view={note.value} />
<ValueWithAddress addressView={address} label='to'>
<></>
</ValueWithAddress>
</div>
<ValueWithAddress addressView={address} label='to'>
<Density medium>

Check failure on line 18 in packages/ui/components/ui/tx/actions-views/output.tsx

View workflow job for this annotation

GitHub Actions / Lint 

'Density' is not defined
<div className='ml-4'>
<ValueViewComponent
valueView={note.value}
context='default'
priority='primary'
hideSymbol={true}
abbreviate={false}
/>
</div>
</Density>
</ValueWithAddress>
}
/>
);
Expand Down
36 changes: 26 additions & 10 deletions packages/ui/components/ui/tx/actions-views/swap/one-way-swap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,32 @@
return (
<div className='flex items-center justify-between'>
<ValueViewComponent view={input} />
<div className='relative mx-2 flex items-center'>
<div className='h-px w-[40px] bg-gray-500' />
<div
className='absolute right-[-6px] size-0'
style={{
borderTop: '6px solid transparent',
borderBottom: '6px solid transparent',
borderLeft: '6px solid gray',
}}
/>
<div className='relative mx-2 flex items-center justify-center'>
<div className='flex items-center justify-center w-16 h-6 rounded-full bg-gray-800 border border-gray-500'>

Check warning on line 18 in packages/ui/components/ui/tx/actions-views/swap/one-way-swap.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Invalid Tailwind CSS classnames order
TalDerei marked this conversation as resolved.
Show resolved Hide resolved
TalDerei marked this conversation as resolved.
Show resolved Hide resolved
<div
className='flex items-center justify-center'
style={{
position: 'relative',
}}
TalDerei marked this conversation as resolved.
Show resolved Hide resolved
>
<div
className='flex items-center'
style={{
width: '14px',
height: '2px',
backgroundColor: 'white',
}}
TalDerei marked this conversation as resolved.
Show resolved Hide resolved
/>
<div
className='w-0 h-0 ml-[2px]'

Check warning on line 34 in packages/ui/components/ui/tx/actions-views/swap/one-way-swap.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Invalid Tailwind CSS classnames order

Check warning on line 34 in packages/ui/components/ui/tx/actions-views/swap/one-way-swap.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Classnames 'w-0, h-0' could be replaced by the 'size-0' shorthand!
style={{
borderTop: '4px solid transparent',
borderBottom: '4px solid transparent',
borderLeft: '6px solid white',
}}
TalDerei marked this conversation as resolved.
Show resolved Hide resolved
/>
</div>
</div>
</div>
<div className='flex items-center justify-end'>
<ValueViewComponent view={output} showValue={!!outputAmount} />
Expand Down
Loading