prep v14.1 release #224
Merged
prep v14.1 release #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it because changing the RPC will force it to still observe the walletCreationHeight? I wonder what the best way to handle that is. If it's the same chain, it's all good. But if not, that is a problem. I suppose given we'll soon remove the ability for folks to add a wallet birthday, we should clear it on rpc changes. Also, not sure if this blocks this release as this is not a new behavior introduced in this new version. |
grod220
approved these changes
Nov 4, 2024
exactly, can we incorporate this into the scope of prax-wallet/prax#226? |
|
Added to description 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@grod220 question about the
change RPC & re-syncuser-flow: should changing the rpc always trigger genesis sync? Currently, it does not.