Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made a special stream for r/all that does handling of skipped items #1328

Closed
wants to merge 2 commits into from
Closed

Made a special stream for r/all that does handling of skipped items #1328

wants to merge 2 commits into from

Conversation

PythonCoderAS
Copy link
Contributor

Fixes # (provide issue number if applicable)
Fix #1043

Feature Summary and Justification

This feature provides a special streamer that proactively fills in missing items

References

@PythonCoderAS
Copy link
Contributor Author

I had to rebuild a comment stream cassette, and reduced it by 75%, so there were a lot of deletions.

@PythonCoderAS
Copy link
Contributor Author

A thought occurred to me. Are skipped comments ones that are removed by AutoMod?

@PythonCoderAS
Copy link
Contributor Author

Follow up testing, and it seems that yes, some comments are removed. I will make this new stream optional.

@bboe
Copy link
Member

bboe commented Mar 1, 2020

Thanks for the efforts here. I'm not really a fan of this auto-incrementing approach being directly in PRAW as I feel like it's a bit of feature creep. Someone who desires this functionality could implement it themselves, or we could provide an example of how to try to get all submissions.

@bboe bboe closed this Mar 1, 2020
@PythonCoderAS PythonCoderAS deleted the stream-dropping branch March 1, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment stream dropping comments?
2 participants