Add documentation notes for outstanding issues #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboe
reviewed
Jan 26, 2020
| @@ -33,8 +33,6 @@ class Message(InboxableMixin, ReplyableMixin, FullnameMixin, RedditBase): | |||
| ``id`` The ID of the message. | |||
| ``name`` The full ID of the message, prefixed with 't4'. | |||
| ``subject`` The subject of the message. | |||
| ``subreddit`` If the message was sent from a subreddit, | |||
There was a problem hiding this comment.
Was this incorrect, or is it no longer provided?
There was a problem hiding this comment.
It's moved to SubredditMessage
bboe
approved these changes
Jan 26, 2020
|
Super awesome. Thanks! |
|
Sorry to interrupt, but I was still working on this branch. I'll just make a new PR with the new changes. |
|
Definitely. Breaking up the PR by file or so is best. Smaller chunks are easier to work with. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds notes for #1241 and #1043