apply filter earlier to let in just 500 responses

Signed-off-by: Lida He <[email protected]>
pravega · May 18, 2018 · 27e0792 · 27e0792
1 parent 75c4815
commit 27e0792
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/flink-examples/src/main/java/io/pravega/examples/flink/alert/HighCountAlerter.java b/flink-examples/src/main/java/io/pravega/examples/flink/alert/HighCountAlerter.java
@@ -94,7 +94,7 @@ public void flatMap(AccessLog value, Collector<ResponseCount> out) throws Except
                     out.collect(new ResponseCount(value.getStatus(), 1));
                 }
             }).filter((FilterFunction<ResponseCount>) count -> {
-                  return !count.response.isEmpty();
+                  return !count.response.equals("500");
               }).keyBy("response")
               .timeWindow(Time.seconds(Constants.ALERT_WINDOW), Time.seconds(Constants.ALERT_INTERVAL))
               .sum("count");
@@ -107,8 +107,7 @@ public void flatMap(AccessLog value, Collector<ResponseCount> out) throws Except
             .where(new SimpleCondition<ResponseCount>() {
                 @Override
                 public boolean filter(ResponseCount value) throws Exception {
-                    return value.count >= Constants.ALERT_THRESHOLD &&
-                           value.response.equals("500");
+                    return value.count >= Constants.ALERT_THRESHOLD;
                 }
             });