-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 81: Customize pravega payload attributes before submitting to make each payload unique #80
Conversation
Signed-off-by: dada-dell-emc <[email protected]>
…lue to enabled or disable customizing payload for pravega Signed-off-by: dada-dell-emc <[email protected]>
40aa6e0
to
fff84c5
Compare
Signed-off-by: dada-dell-emc <[email protected]>
driver-pravega/src/main/java/io/openmessaging/benchmark/driver/pravega/CustomPayloadUtils.java
Show resolved
Hide resolved
driver-pravega/src/main/java/io/openmessaging/benchmark/driver/pravega/CustomPayloadUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: dada-dell-emc <[email protected]>
driver-pravega/src/main/java/io/openmessaging/benchmark/driver/pravega/CustomPayloadUtils.java
Show resolved
Hide resolved
Did we verify these changes through any tests? |
driver-pravega/src/main/java/io/openmessaging/benchmark/driver/pravega/CustomPayloadUtils.java
Show resolved
Hide resolved
driver-pravega/src/main/java/io/openmessaging/benchmark/driver/pravega/CustomPayloadUtils.java
Show resolved
Hide resolved
...main/java/io/openmessaging/benchmark/driver/pravega/PravegaBenchmarkTransactionProducer.java
Show resolved
Hide resolved
We verified these changes from logs, there is no test cases for drivers |
Signed-off-by: dada-dell-emc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sachin-j-joshi @dada-dell-emc do you know that the most recent version of the Pravega benchmark is in the official repository? https://github.com/openmessaging/benchmark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the intention of this PR is just to make payloads unique on a per-write basis, please consider a more efficient approach, as the current one looks quite expensive for a benchmark. Also, please note my comment about contributing in the future (maybe not this change, but future improvements such as upgrading dependencies) to the official OpenMessaging Benchmark repo, as we contributed the Pravega driver there a couple of years back: https://github.com/openmessaging/benchmark/tree/master/driver-pravega
driver-pravega/src/main/java/io/openmessaging/benchmark/driver/pravega/CustomPayloadUtils.java
Show resolved
Hide resolved
driver-pravega/src/main/java/io/openmessaging/benchmark/driver/pravega/CustomPayloadUtils.java
Show resolved
Hide resolved
Signed-off-by: dada-dell-emc <[email protected]>
These changes are mainly just to submit the payload into pravega and not benchmarking pravega, so that QE can maintain throughput for their end to end testing. |
@dada-dell-emc I have merged this PR based on 3 approvals. Please work towards addressing issues |
…hmark#80 Signed-off-by: dada-dell-emc <[email protected]>
Change log description
Added changes to customize pravega payload Timestamp attribute before submitting to Pravega, to make each payload unique.
Purpose of the change
Fixes #81.
What the code does
This PR does the following:
Introduced new boolean configuration attribute customPayload.
If customPayload is set to true, then customize json request payload with Timestamp dynamic value in ms.
How to verify it
Enable customPayload configuration for pravega and then run omb for pravega driver with sample payload custom-payload-idrac.data and workload custom-payload-idrac.yaml shared in this repository.
After that when you read those messages in pravega consumer check Timestamp attribute value, you will get different values almost each time in milliseconds. Or you can enble debug log in omb which will print customized payload for pravega, check Timestamp attribute value,it will print different values almost each time in milliseconds.