[issue-717] Let Pravega internal thread pool deal with checkpoint #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Zhou <[email protected]>
Signed-off-by: Brian Zhou <[email protected]>
ShwethaSNayak
approved these changes
Jul 14, 2023
tkaitchuck
approved these changes
Jul 14, 2023
|
The test failure is because of this code change, looks like the change introduce a deadlock in the client internal thread in the read group. We cannot make such change. |
Signed-off-by: Brian Zhou <[email protected]>
Signed-off-by: Brian Zhou <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #718 +/- ##
============================================
+ Coverage 81.12% 81.23% +0.11%
- Complexity 573 574 +1
============================================
Files 62 62
Lines 2723 2723
Branches 232 232
============================================
+ Hits 2209 2212 +3
+ Misses 326 324 -2
+ Partials 188 187 -1
☔ View full report in Codecov by Sentry. |
Welkin-Y
pushed a commit
to Welkin-Y/Pravega-flink-connectors
that referenced
this pull request
Oct 30, 2023
…avega#718) Signed-off-by: Brian Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Use
ReaderGroup::initiateCheckpoint(checkpointName)to perform the checkpointPurpose of the change
Fixes #717
What the code does
Update the method
Update the Pravega version
How to verify it
./gradlew clean buildpasses