Pop-up and Options page #14
Conversation
|
This seems nice, but the options page needs to be a separate page because it can also be accessed from the extension menu. But I really liked your idea, so I would suggest moving the options code to popup. And rename it something like Also just use something like this to reverse the object, so that we have the recently saved URLs first. And slice it to show the top 5 URLs, since we are going to show all of them in the options page anyway. |
|
sure thing! I had something similar in mind, just needed some validation. |
|
@yuvrajsharma07 I have updated the master branch so please update your branch accordingly. Also, let me know if you're stuck anywhere. |
# Conflicts: # options.js # save.js
|
Yeah! I have even styled the options page, added some bar indicating the percentage as well. Will do the popup object reverse thing and commit soon. Here is a snippet |
|
Also, I am planning to go forward with #15 for the options page |
|
Yeah, completely forgot about that file. Modified the options page to maintain design consistency with the popup, otherwise it's your call :) Please check the code for the reverse object. Pushed the items to an array, reversed it and displayed only the first 5. |
# Conflicts: # options.css # popup.css # popup.html # popup.js
|
You did not removed the merge conflict indicators again. |
options.css
Outdated
|
|
||
|
|
||
| >>>>>>> devfolioco/master |
|
I took the liberty of using a different font to make it all look better, do remark on that too |
# Conflicts: # delete.js # options.css # options.html # options.js
# Conflicts: # options.css
# Conflicts: # popup.html
|
Moving in a different direction, so won't be able to merge it for now. Thanks for experimenting with this. |
The pop-up window has been improved with a little bit of responsive behaviour, along with font-family changes all over the doc. The options section has also been modified.
Addresses issue Improve the popup sheet #1 and Improve the options page #9 .