Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Husky, Lint-Staged and Prettier to the project #121

Closed
wants to merge 1 commit into from

Conversation

nirmalhk7
Copy link

Signed-off-by: Nirmal Khedkar [email protected]

  • What does this PR do?
    Fixes Automatically Prettify after every commit using Husky and Lint-Staged #112 .
  • Any background context you want to provide?
    Basically, this PR introduces Prettier, Husky and Lint-Staged to the project: every commit made in this project from this PR onwards, if it matches the condition's we've set in package.json, will be stylised automatically. This reduces a lot of time spent in pin-pointing incorrect coding practices.

Although prettier suggests to stick to the default settings for code styling, I'm okay to implement some specific settings if the community demands. Please go through the options prettier provides here.

Signed-off-by: Nirmal Khedkar <[email protected]>
@prateek3255
Copy link
Owner

Can you also add ESLint with autofix on save?

@nirmalhk7
Copy link
Author

nirmalhk7 commented Oct 11, 2020

I'm aware that eslint --fix will fix any linter warnings, but I'm not aware of any command to fix ESlint warnings on save, that's something that'd need to be set up in your particular code editor (here's a tutorial for VSCode).

Should I simply add eslint --fix?

@nirmalhk7
Copy link
Author

@prateek3255 I understand you must be busy, but I'd like an update on this. Thank you :)

Base automatically changed from master to main January 20, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically Prettify after every commit using Husky and Lint-Staged
2 participants