Some minor waybar fixes and enhancements #1469

its-19818942118 · 2024-05-10T12:08:29Z

Pull Request

Description

some minor fixes of waybar alignments issues. added fonts but didnt know how to make so the scripts read the fonts. waybar works fine. added seconds hand on the clock.

Please read these instructions and remove unnecessary text.

Type of change

Please put an x in the boxes that apply:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (non-breaking change; modified files are limited to the documentations)
Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
Other (provide details below)

Checklist

Please put an x in the boxes that apply:

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

…ancements

its-19818942118 · 2024-05-13T04:51:10Z

@kRHYME7 @Skerse @rubiin @prasanthrangan

abenezerw · 2024-05-13T06:06:28Z

looks fine here.

abenezerw

Checked the files out on my pc. they work fine on most of the styles of the waybar, on some the whole thing becomes zoomed in.

rubiin · 2024-05-13T06:51:58Z

Checked the files out on my pc. they work fine on most of the styles of the waybar, on some the whole thing becomes zoomed in.

can you also share the zoomed in screenshots. Will help in reviewing pr

kRHYME7 · 2024-05-13T07:35:10Z

default:

PR

TBH, I really like it! I did not check the files changed though, but please be sure not to hard code some values if possible, in case.

Overall, this is neat! Will further test this.

Spacing issues:

abenezerw · 2024-05-13T07:37:50Z

Checked the files out on my pc. they work fine on most of the styles of the waybar, on some the whole thing becomes zoomed in.

can you also share the zoomed in screenshots. Will help in reviewing pr

abenezerw · 2024-05-13T07:41:38Z

By the way im using a lenovo legion laptop and it has a feature where you can set the battery to be stuck around 60% and use it while charging to prevent long term battery damage, i always use it charging and was wondering if the script has any parts i could alter to swap to plugged in icon in this state.
A suggestion for the network/wifi icons. why not combine them i personally like the three dotted wifi icon. but the other one where it shows network when hovered on seems to be unused. maybe combine them to have more space?

kRHYME7 · 2024-05-13T07:49:47Z

@abenezerw

re:1. This is handled by the battery module of waybar itself, so the display is based on the default waybar program. This is not handled by any user scripts

re:2. we can't the other one is a system tray Icon other is a module.(if someone wants to make custom script to launch rofi and works like how nm-applet does, it would be nice. )

abenezerw · 2024-05-13T07:57:52Z

cool, ill go try the swaync pr next.

kRHYME7 · 2024-05-13T08:10:12Z

One more note to anyone tetsing a PR and preserving their current configs

Hyde backup all backs up your config (name it to something you remember)

Hyde --dev then select pull request

Hyde restore Config to populate the Configs
repeat

to revert back to your back up Hyde backup revert select the backup.

its-19818942118 · 2024-05-13T08:17:17Z

default:

PR

TBH, I really like it! I did not check the files changed though, but please be sure not to hard code some values if possible, in case.

Overall, this is neat! Will further test this.

Spacing issues:

tell me the moddules which have spacing issues. none of this is tested on local cuz my waybar is broken. but yeah if you let me know i can fix it. i can also make more custom layouts.

edit: this seems to be like screen scaling. cuz i have a small screen. so it was perfect on my side. but i think i need to add mono spaced fonts.

abenezerw · 2024-05-13T08:21:40Z

default:
PR
TBH, I really like it! I did not check the files changed though, but please be sure not to hard code some values if possible, in case.
Overall, this is neat! Will further test this.
Spacing issues:

tell me the moddules which have spacing issues. none of this is tested on local cuz my waybar is broken. but yeah if you let me know i can fix it. i can also make more custom layouts.

edit: this seems to be like screen scaling. cuz i have a small screen. so it was perfect on my side. but i think i need to add mono spaced fonts.

i agree with the screen scaling cause the modules dont collide on my end too

rubiin · 2024-05-13T09:39:54Z

default:
PR
TBH, I really like it! I did not check the files changed though, but please be sure not to hard code some values if possible, in case.
Overall, this is neat! Will further test this.
Spacing issues:

tell me the moddules which have spacing issues. none of this is tested on local cuz my waybar is broken. but yeah if you let me know i can fix it. i can also make more custom layouts.

edit: this seems to be like screen scaling. cuz i have a small screen. so it was perfect on my side. but i think i need to add mono spaced fonts.

Will also give it a test when I am free

its-19818942118 · 2024-05-13T09:48:23Z

Checked the files out on my pc. they work fine on most of the styles of the waybar, on some the whole thing becomes zoomed in.

can you also share the zoomed in screenshots. Will help in reviewing pr

this is because the icon size is in percentage. depending on the space and height it will adjust. i made it so that it isnt hardcoded. i guess need to fix it. but my waybar just broke so i couldnt test any of this

abenezerw · 2024-05-13T15:40:26Z

Whats the edit?
@its-19818942118

its-19818942118 · 2024-05-13T15:53:28Z

default:
PR
TBH, I really like it! I did not check the files changed though, but please be sure not to hard code some values if possible, in case.
Overall, this is neat! Will further test this.
Spacing issues:

tell me the moddules which have spacing issues. none of this is tested on local cuz my waybar is broken. but yeah if you let me know i can fix it. i can also make more custom layouts.
edit: this seems to be like screen scaling. cuz i have a small screen. so it was perfect on my side. but i think i need to add mono spaced fonts.

Will also give it a test when I am free

sure and will be adding more functionality over all

its-19818942118 · 2024-05-13T15:54:13Z

Whats the edit? @its-19818942118

i shared lol

its-19818942118 · 2024-05-13T15:57:04Z

also someone pls test pulse audio cuz my system doesnt have audio. so nothing works. no audio cuz my drivers dont work idk why. but yeah let me if you find something

abenezerw · 2024-05-13T16:16:00Z

There's this text on hover.

its-19818942118 · 2024-05-13T17:14:21Z

ok i just tested this but mono spaced fonts make it look janky and unprofessional. so unfortunately i cant implement a mono spaced font it ruins it. check the before and after you guys. trust me it makes the older version look shit

its-19818942118 · 2024-05-13T17:20:23Z

also @kRHYME7 i found the issue its seems to be the network icon that is interfering and making it collide

edit: its the backlight icon and the spacing of it. cuz if you look closely you will see that there is too much space. like 2 spaces. so yeah. let me see what i can do

abenezerw · 2024-05-13T17:21:50Z

ok i just tested this but mono spaced fonts make it look janky and unprofessional. so unfortunately i cant implement a mono spaced font it ruins it. check the before and after you guys. trust me it makes the older version look shit

Haha, did you fix the *span issue

its-19818942118 · 2024-05-13T17:37:09Z

ok i just tested this but mono spaced fonts make it look janky and unprofessional. so unfortunately i cant implement a mono spaced font it ruins it. check the before and after you guys. trust me it makes the older version look shit

Haha, did you fix the *span issue

@abenezerw which one

abenezerw · 2024-05-13T17:38:59Z

ok i just tested this but mono spaced fonts make it look janky and unprofessional. so unfortunately i cant implement a mono spaced font it ruins it. check the before and after you guys. trust me it makes the older version look shit

Haha, did you fix the *span issue

@abenezerw which one

Hover over brightness, audio, mic or updates. It shows extra text. See the screenshot I left above.

its-19818942118 · 2024-05-13T18:53:20Z

ok i just tested this but mono spaced fonts make it look janky and unprofessional. so unfortunately i cant implement a mono spaced font it ruins it. check the before and after you guys. trust me it makes the older version look shit

Haha, did you fix the *span issue

@abenezerw dont have it on my end. i dont get any tooltip lol

its-19818942118 · 2024-05-13T19:25:27Z

ok i just tested this but mono spaced fonts make it look janky and unprofessional. so unfortunately i cant implement a mono spaced font it ruins it. check the before and after you guys. trust me it makes the older version look shit

Haha, did you fix the *span issue

@abenezerw broo i didnt get this issue on my end lol

its-19818942118 · 2024-05-13T19:48:05Z

aight guys created a dev server just for feedback on pr and new stuff and dev discussion. cuz the HyDE server just makes it cluttered and people feel lost. plus github isnt really intuitive for chatting. if you want to you can join the server.
https://discord.gg/FYJQT9DReV

its-19818942118 · 2024-05-20T03:06:52Z

Ok the tooltip thing is fixed substitution with hard coded icons cuz if not it still prints out the guts that fixes the icons. Had not choice 😕😞

its-19818942118 · 2024-05-25T14:55:48Z

@kRHYME7 @prasanthrangan ready to go. pls approve this. i need more feedback on this.

kRHYME7

This "minor" is not minor to me. Well, looks good though! 🫰

its-19818942118 · 2024-06-17T15:27:14Z

This "minor" is not minor to me. Well, looks good though! 🫰

what compared to oothers works mine is minimal af. people have good shit i am just tweaking a bit of the waybar to make the ui look nice. lol @kRHYME7

kRHYME7 · 2024-06-17T15:47:31Z

Hard-coded colors too.

its-19818942118 · 2024-06-17T17:32:27Z

Well yeah colors need to be hardcoded or it looks messed up 😅

its-19818942118 · 2024-06-19T05:20:38Z

@prasanthrangan

its-19818942118 · 2024-06-29T13:49:35Z

@rishav12s

dieBakterie · 2024-07-03T15:37:34Z

The right click entry for the audio selector is missing in your pulseaudio.jsonc

its-19818942118 · 2024-07-07T09:38:50Z

The right click entry for the audio selector is missing in your pulseaudio.jsonc

i added it. i am sure i did

abenezerw

Finally got to trying this out again, still looks okay. but i guess this counts as big changes so its not merged maybe.

its-19818942118 · 2024-11-04T10:00:51Z

@abenezerw 😭 io will just close this

its-19818942118 added 6 commits May 9, 2024 07:48

Fixing waybar Alignment issues

787d606

minor waybar enhancements

775cacf

Added symbols nerd font for waybar font substitution

c142314

Merge branch 'prasanthrangan:main' into main

7ba9b06

Some Major and Minor waybar alignment fixes and some other waybar enh…

e86985d

…ancements

Merge branch 'prasanthrangan:main' into main

1c2ae11

abenezerw reviewed May 13, 2024

View reviewed changes

its-19818942118 requested a review from abenezerw May 13, 2024 14:49

its-19818942118 marked this pull request as draft May 13, 2024 14:49

Merge branch 'prasanthrangan:main' into main

8563965

fix network.jsonc alignment

05eb737

some adjustments

e8f7a51

its-19818942118 marked this pull request as ready for review May 25, 2024 14:54

kRHYME7 reviewed Jun 17, 2024

View reviewed changes

its-19818942118 requested a review from kRHYME7 June 19, 2024 05:20

its-19818942118 added 2 commits June 29, 2024 20:01

Update backlight.jsonc

a5ac8ca

Update battery.jsonc

ff6e580

rishav12s approved these changes Jun 29, 2024

View reviewed changes

Update pulseaudio.jsonc

f21d38c

abenezerw reviewed Nov 4, 2024

View reviewed changes

Some minor waybar fixes and enhancements #1469

Are you sure you want to change the base?

Some minor waybar fixes and enhancements #1469

Conversation

its-19818942118 commented May 10, 2024 • edited Loading

Pull Request

Description

Type of change

Checklist

Screenshots

Additional context

its-19818942118 commented May 13, 2024

abenezerw commented May 13, 2024

abenezerw left a comment

Choose a reason for hiding this comment

rubiin commented May 13, 2024

kRHYME7 commented May 13, 2024

abenezerw commented May 13, 2024

abenezerw commented May 13, 2024

kRHYME7 commented May 13, 2024 • edited Loading

abenezerw commented May 13, 2024

kRHYME7 commented May 13, 2024

its-19818942118 commented May 13, 2024 • edited Loading

abenezerw commented May 13, 2024

rubiin commented May 13, 2024

its-19818942118 commented May 13, 2024

abenezerw commented May 13, 2024 • edited Loading

its-19818942118 commented May 13, 2024

its-19818942118 commented May 13, 2024

its-19818942118 commented May 13, 2024

abenezerw commented May 13, 2024

its-19818942118 commented May 13, 2024

its-19818942118 commented May 13, 2024 • edited Loading

abenezerw commented May 13, 2024 • edited Loading

its-19818942118 commented May 13, 2024

abenezerw commented May 13, 2024

its-19818942118 commented May 13, 2024

its-19818942118 commented May 13, 2024

its-19818942118 commented May 13, 2024

its-19818942118 commented May 20, 2024

its-19818942118 commented May 25, 2024

kRHYME7 left a comment

Choose a reason for hiding this comment

its-19818942118 commented Jun 17, 2024

kRHYME7 commented Jun 17, 2024

its-19818942118 commented Jun 17, 2024

its-19818942118 commented Jun 19, 2024

its-19818942118 commented Jun 29, 2024

dieBakterie commented Jul 3, 2024

its-19818942118 commented Jul 7, 2024

abenezerw left a comment

Choose a reason for hiding this comment

its-19818942118 commented Nov 4, 2024

its-19818942118 commented May 10, 2024 •

edited

Loading

kRHYME7 commented May 13, 2024 •

edited

Loading

its-19818942118 commented May 13, 2024 •

edited

Loading

abenezerw commented May 13, 2024 •

edited

Loading

its-19818942118 commented May 13, 2024 •

edited

Loading

abenezerw commented May 13, 2024 •

edited

Loading