Skip to content

Commit

Permalink
refactor(ci): Minor yml cleanup (microsoft#22660)
Browse files Browse the repository at this point in the history
## Description

- Remove a `workingDir` node at the incorrect indentation level. The
script itself checks if that directory exists before `cd`ing into it if
applicable, so having it run in it from the start doesn't seem necessary
(and might even fail if it doesn't exist?)
- Replace a few `tag` strings with the more explicit `Tag image` in
`Docker@1` tasks, as listed [in the
docs](https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/docker-v1?view=azure-pipelines).
`tag` works as an alias, but the explicit version helps so VSCode
doesn't report problems/unexpected values in yml files.
  • Loading branch information
alexvy86 authored Sep 27, 2024
1 parent 954f465 commit 107be83
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,13 @@ jobs:
- task: Docker@1
displayName: Tag image as '$(containerTagSuffix)'
inputs:
command: 'tag'
command: 'Tag image'
arguments: '${{ parameters.containerTag }} ${{ parameters.containerRegistryUrl }}/${{ parameters.containerName }}:$(containerTagSuffix)'

- task: Docker@1
displayName: Tag image as 'latest'
inputs:
command: 'tag'
command: 'Tag image'
arguments: '${{ parameters.containerTag }} ${{ parameters.containerRegistryUrl }}/${{ parameters.containerName }}:latest'

- task: 1ES.PushContainerImage@1
Expand Down
1 change: 0 additions & 1 deletion tools/pipelines/templates/include-test-real-service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,6 @@ stages:
displayName: Filter skipped test from report
condition: succeededOrFailed()
inputs:
workingDir: ${{ variables.testPackageDir }}/nyc
targetType: 'inline'
script: |
if [[ -d ${{ variables.testPackageDir }}/nyc ]]; then
Expand Down

0 comments on commit 107be83

Please sign in to comment.