Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status to multiplayer_rooms #11681

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Conversation

smoogipoo
Copy link
Contributor

Enum to support possible future expansion.

This doesn't contain the full array the client would normally use ( open, open_private, playing, ended ) because the "ended" state is difficult to handle at osu!web's end for playlist rooms.

So idle now represents ( open, open_private, ended ) and the client will figure out it from there.

@nanaya
Copy link
Collaborator

nanaya commented Nov 22, 2024

This adds the column at the end which I don't mind but if @peppy (or someone) cares to put it somewhere else the migration will need an ->after(...)

@peppy
Copy link
Member

peppy commented Nov 23, 2024

As mentioned elsewhere, open and open_private shouldn't be grouped in the same enum as playing/ended because you're losing the private state for the latter two.

But since the opening post, these have been removed so I guess it's fine.

@peppy peppy merged commit 3efdafb into ppy:master Nov 23, 2024
3 checks passed
@smoogipoo
Copy link
Contributor Author

This adds the column at the end

I only put it there because I noticed category is already there. I imagine you can do a migration to move it around later on?

But since the opening post, these have been removed so I guess it's fine

The OP is post- that idea. I.e. it's a catch all state for all of those that have to be decided by some other method later on depending on on end date / password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants