Add platform issue tags #11428
Add platform issue tags #11428
Conversation
|
Do these buttons actually fit? Can you provide a screenshot showing how this looks? Also I don't think we need localisation for any of this. |
|
Updated the OP with a screenshot. As for translations, it's built into issue tags workflow so is easier to just go that way rather than omitting it, it's only tooltips and success messages that get translated anyway, the tag itself doesn't. |
|
is it possible to replace the icons with text? might make it more legible than almost-understandable icons. laz / stb / web maybe. |
|
Guess that works, done so. |
| function platform_issue_text($issue) | ||
| { | ||
| return match ($issue) { | ||
| 'lazer' => 'laz', |
There was a problem hiding this comment.
lzr feels like a better acronym than laz, thoughts?
| 'lazer' => 'laz', | |
| 'lazer' => 'lzr', |
| @@ -10,7 +10,7 @@ | |||
| @include('forum.topics._moderate_move', compact('topic')) | |||
|
|
|||
| @if ($topic->isIssue()) | |||
| @foreach ($topic::ISSUE_TAGS as $type) | |||
| @foreach (array_merge($topic::ISSUE_TAGS, $topic::PLATFORM_ISSUE_TAGS) as $type) | |||
| @include("forum.topics._issue_tag_{$type}") | |||
There was a problem hiding this comment.
or
@include('forum.topics._issue_tag', ['issueTag' => $type])and no extra blade templates
| if (in_array($tag, static::PLATFORM_ISSUE_TAGS, true)) { | ||
| $tag = "osu!{$tag}"; | ||
| } |
There was a problem hiding this comment.
probably move this logic to its own method cuz it comes up 3 times (tagForTopicTitle() or something)
alternatively include the prefix in each PLATFORM_ISSUE_TAGS
|
also I think it would be good to combine the |
|
feels like the tags should just be moved to a menu with this amount |
|
I wouldn't be against that. |
|
Making a new panel for the buttons would be nice, I wouldn't mind that. Though this design works fine as well since only a few people are using the buttons it really wouldn't matter either way. Thanks for the quick work Venix, I appreciate it. |
| @@ -103,6 +103,12 @@ class Topic extends Model implements AfterCommit | |||
| 'topic_title' => 100, | |||
| ]; | |||
|
|
|||
| const PLATFORM_ISSUE_TAGS = [ | |||
| 'lazer', | |||
There was a problem hiding this comment.
str_slug the type (class name, translation, filename) and use the actual tag string everywhere else instead? The icon helper can just generate the full content (stb etc string for the new tags and <i ...> for everything else)
| @@ -25,6 +25,10 @@ class=" | |||
| data-method="post" | |||
| > | |||
| <span class="btn-circle__content"> | |||
| <i class="{{ issue_icon($issueTag) }}"></i> | |||
| @if (in_array($issueTag, $topic::ISSUE_TAGS, true)) | |||
There was a problem hiding this comment.
view forum.forums._topic also needs adjustment
This adds buttons for "[osu!lazer]", "[osu!stable]", and "[osu!web]" thread title tagging, as of request of help forum moderators.
Uses separate const from regular tags as it doesn't have icon thing, and is supposed to be visible in thread names in the listing.
Also, genuinely had no idea for icons so they could be better possibly, though a mod-only feature so probably shouldn't matter as much 🤷.It is text now.In order: osu!lazer, osu!stable, osu!web
