wip

internal/controller/http/v1/invites.go

@@ -46,16 +46,18 @@ func (r *InvitesRoutes) acceptInvite(c *gin.Context) {
 		InvitedVia: m.Code,
 	})
 	if err != nil {
-		r.logger.Debug().Err(err).Str("email", m.Email).Str("code", m.Code).
-			Msg("failed to accept invite")
-		switch {
-		case errors.Is(err, entity.ErrAlreadyExists):
+		if errors.Is(err, entity.ErrAlreadyExists) {
+			r.logger.Debug().Str("email", m.Email).Str("code", m.Code).Msg("user with the same email already exists")
 			c.Status(http.StatusConflict)
-		case errors.Is(err, entity.ErrNotAvailable):
+			return
+		}
+		if errors.Is(err, entity.ErrNotAvailable) {
+			r.logger.Debug().Str("email", m.Email).Str("code", m.Code).Msg("no invitation available")
 			c.Status(http.StatusGone)
-		default:
-			c.Status(http.StatusInternalServerError)
+			return
 		}
+		r.logger.Err(err).Str("email", m.Email).Str("code", m.Code).Msg("failed to accept invite")
+		c.Status(http.StatusInternalServerError)
 		return
 	}
 

internal/usecase/service.go

@@ -2,7 +2,6 @@ package usecase
 
 import (
 	"context"
-	"errors"
 	"fmt"
 
 	"github.com/pprishchepa/go-invitecoder-example/internal/config"
@@ -43,13 +42,11 @@ func (s *InviteService) AcceptInvite(ctx context.Context, user entity.InvitedUse
 		return fmt.Errorf("inc by code: %w", err)
 	}
 
-	if err := s.users.SaveUser(ctx, user); err != nil {
-		if errors.Is(err, entity.ErrAlreadyExists) {
-			if err := s.stats.DecByCode(ctx, user.InvitedVia); err != nil {
-				s.logger.Err(err).Msg("could not rollback stats increment")
-			}
+	if saveErr := s.users.SaveUser(ctx, user); saveErr != nil {
+		if decErr := s.stats.DecByCode(ctx, user.InvitedVia); decErr != nil {
+			s.logger.Err(decErr).Msg("could not rollback stats increment")
 		}
-		return fmt.Errorf("save user: %w", err)
+		return fmt.Errorf("save user: %w", saveErr)
 	}
 
 	return nil