add character limit for pipeline run name

ppadti · Jun 5, 2024 · 2ac835b · 2ac835b
1 parent 2b19ddb
commit 2ac835b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/frontend/src/concepts/k8s/NameDescriptionField.tsx b/frontend/src/concepts/k8s/NameDescriptionField.tsx
@@ -22,6 +22,7 @@ type NameDescriptionFieldProps = {
   autoFocusName?: boolean;
   showK8sName?: boolean;
   disableK8sName?: boolean;
+  maxLength?: number;
 };
 
 const NameDescriptionField: React.FC<NameDescriptionFieldProps> = ({
@@ -32,6 +33,7 @@ const NameDescriptionField: React.FC<NameDescriptionFieldProps> = ({
   autoFocusName,
   showK8sName,
   disableK8sName,
+  maxLength,
 }) => {
   const autoSelectNameRef = React.useRef<HTMLInputElement | null>(null);
 
@@ -61,7 +63,13 @@ const NameDescriptionField: React.FC<NameDescriptionFieldProps> = ({
             name={nameFieldId}
             value={data.name}
             onChange={(e, name) => setData({ ...data, name })}
+            maxLength={maxLength}
           />
+          {maxLength && (
+            <HelperText>
+              <HelperTextItem>{`Cannot exceed ${maxLength} characters`}</HelperTextItem>
+            </HelperText>
+          )}
         </FormGroup>
       </StackItem>
       {showK8sName && (

diff --git a/frontend/src/concepts/pipelines/content/createRun/RunForm.tsx b/frontend/src/concepts/pipelines/content/createRun/RunForm.tsx
@@ -72,6 +72,7 @@ const RunForm: React.FC<RunFormProps> = ({ data, runType, onValueChange }) => {
           descriptionFieldId="run-description"
           data={data.nameDesc}
           setData={(nameDesc) => onValueChange('nameDesc', nameDesc)}
+          maxLength={255}
         />
 
         {isSchedule && data.runType.type === RunTypeOption.SCHEDULED && (