Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses @powsybl/diagram-viewer to build jupyter notebook widgets (updated) #4

Merged
merged 19 commits into from
Apr 15, 2024
Merged

Uses @powsybl/diagram-viewer to build jupyter notebook widgets (updated) #4

merged 19 commits into from
Apr 15, 2024

Conversation

CBiasuzzi
Copy link
Contributor

Please check if the PR fulfills these requirements

  • [x ] The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Feature / experimentation

What is the new behavior (if this is a feature change)?

it provides:

  • an SVG viewer widget with pan and zoom, using @powsybl/diagram-viewer.
  • a network explorer widget that uses basic widgets and the SVG viewer from @powsybl/diagram-viewer, to search voltage levels in the network and display them.
  • an SLD viewer widget customizable with callbacks, using the SingleLineDiagramViewer from @powsybl/diagram-viewer.
  • an interactive network explorer widget, built using the SLD viewer.

@CBiasuzzi
adds a SvgSldView widget based on the single-line-diagram-viewer
08e179e 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
fixes
e46c1f1 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
recreated build template from the latest widget-ts-cookiecutter; upda…
c67cbae 
…tes build dependencies to python 3.11, node 18 and jupyter-lab 3.6

Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
adds a first, basic explorer widget (composition of existing widgets …
1eb79bb 
…and the SVG viewer)

Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
aligns code to the latest version of diagram-viewer
c3a13f5 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
Copy link
Contributor Author

Note that this PR includes code from both PRs #2 and
#3

@CBiasuzzi
aligns dependencies to the latest widget-ts-cookiecutter's, to make i…
569d3c3 
…t work with python 3.12 and jupyterlab >= 4

Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
fixes updated jest's' configs
4d3ded4 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
fixes lint warnings
a5bf759 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
fixes lint
1a92ebf 
Signed-off-by: Christian Biasuzzi <[email protected]>
@flo-dup flo-dup self-requested a review February 22, 2024 12:13
flo-dup
flo-dup requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job! just a few polishing comments

pypowsybl_jupyter/explorer.py Outdated Show resolved Hide resolved
pypowsybl_jupyter/explorer.py Outdated Show resolved Hide resolved
pypowsybl_jupyter/explorer.py Outdated Show resolved Hide resolved
pypowsybl_jupyter/explorer.py Outdated Show resolved Hide resolved
pypowsybl_jupyter/explorer.py Outdated Show resolved Hide resolved
examples/demo_sld.ipynb Outdated Show resolved Hide resolved
examples/demo_sld.ipynb Outdated Show resolved Hide resolved
pypowsybl_jupyter/explorersld.py Show resolved Hide resolved
examples/demo_sld_explorer.ipynb Outdated Show resolved Hide resolved
src/widget.ts Outdated Show resolved Hide resolved
@CBiasuzzi
refinements
e98dc7c 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
fixes gitignore
953530f 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
adds to the SLD explorer the ability to toggle a switch.
c3a444d 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
updates the diagram-viewer dependency
b8bce93 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
moves diagrams' border declaration style to the .css and applies it c…
a2df3ce 
…onsistently to the widgets

Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
fixes lint-related issues
4eaba7e 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
adds instructions about creating a .whl package
821f181 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
fixes (reduces cell flickering with the SLD explorer)
7d8effb 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
fixes typo
05f11e8 
Signed-off-by: Christian Biasuzzi <[email protected]>
@CBiasuzzi
improves readability: splits widgets code in multiple files (one per …
0c24be7 
…widget), renames files and references, accordingly

Signed-off-by: Christian Biasuzzi <[email protected]>
@flo-dup flo-dup merged commit 7e924d4 into main Apr 15, 2024
3 checks passed
@flo-dup flo-dup deleted the sld_widget_new branch April 15, 2024 09:44
This was referenced Apr 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-dup flo-dup flo-dup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CBiasuzzi @flo-dup