Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimization tests for OpenReac indicators and bounds #88

Merged
merged 31 commits into from
Jan 8, 2025

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Dec 12, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No.

What kind of change does this PR introduce?

New TUs are added, to test OpenReac indicators and generator bounds management in ACOPF.

What is the current behavior?

No such test exists.

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Sorry, something went wrong.

Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Clean
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Clean
Signed-off-by: p-arvy <[email protected]>
@p-arvy p-arvy changed the base branch from main to refactor-open-reac-tests December 12, 2024 15:52
@p-arvy
Copy link
Member Author

p-arvy commented Dec 12, 2024

Just changed the branch base temporarily, to facilitate the review, until the PR #83 is merged.

@p-arvy p-arvy force-pushed the add-optimization-tests branch from b7a6d08 to a87f58a Compare December 17, 2024 18:08
@p-arvy p-arvy changed the base branch from refactor-open-reac-tests to computer-and-time-as-debug-indicators December 17, 2024 18:08
@p-arvy p-arvy added the Java label Dec 19, 2024
@p-arvy p-arvy requested a review from So-Fras December 19, 2024 09:42
@p-arvy p-arvy self-assigned this Dec 19, 2024
@p-arvy p-arvy force-pushed the add-optimization-tests branch from 786bef7 to be08608 Compare December 19, 2024 16:19
@p-arvy p-arvy mentioned this pull request Dec 30, 2024
7 tasks
Clean
Signed-off-by: p-arvy <[email protected]>
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

1 similar comment
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Clean
Signed-off-by: p-arvy <[email protected]>
@p-arvy p-arvy force-pushed the computer-and-time-as-debug-indicators branch from ef4ffb5 to abfc91b Compare December 30, 2024 11:32
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
@p-arvy p-arvy force-pushed the add-optimization-tests branch from f3b46d9 to f5149f3 Compare December 30, 2024 11:41
@p-arvy p-arvy requested a review from So-Fras December 30, 2024 11:43
p-arvy and others added 8 commits January 8, 2025 14:56
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Merge
Signed-off-by: Sophie Frasnedo <[email protected]>
@So-Fras So-Fras changed the base branch from computer-and-time-as-debug-indicators to main January 8, 2025 14:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Sophie Frasnedo <[email protected]>
Copy link

sonarqubecloud bot commented Jan 8, 2025

@So-Fras So-Fras merged commit 178f1f7 into main Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants