-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Division of AMPL code in functional blocks #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Quality Gate passedIssues Measures |
# Conflicts: # open-reac/src/main/resources/openreac/reactiveopf.mod # open-reac/src/main/resources/openreac/reactiveopf.run # open-reac/src/main/resources/openreac/reactiveopfexit.run # open-reac/src/main/resources/openreac/reactiveopfoutput.run
Signed-off-by: p-arvy <[email protected]>
p-arvy
changed the title
|WIP] Division of AMPL code in functional blocks
Division of AMPL code in functional blocks
Jul 12, 2024
klorel
approved these changes
Jul 15, 2024
So-Fras
requested changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments!
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Quality Gate passedIssues Measures |
So-Fras
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Yes, #20.
What kind of change does this PR introduce?
The AMPL code of OpenReac is divided into functional blocks.
What is the current behavior?
These blocks are grouped into
reactiveopf.mod
andreactiveopf.run
files.What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: