Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division of AMPL code in functional blocks #71

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Jun 5, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Yes, #20.

What kind of change does this PR introduce?

The AMPL code of OpenReac is divided into functional blocks.

What is the current behavior?

These blocks are grouped into reactiveopf.mod and reactiveopf.run files.

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@p-arvy p-arvy self-assigned this Jun 5, 2024
Copy link

sonarqubecloud bot commented Jun 5, 2024

p-arvy added 2 commits July 12, 2024 14:11
# Conflicts:
#	open-reac/src/main/resources/openreac/reactiveopf.mod
#	open-reac/src/main/resources/openreac/reactiveopf.run
#	open-reac/src/main/resources/openreac/reactiveopfexit.run
#	open-reac/src/main/resources/openreac/reactiveopfoutput.run
@p-arvy p-arvy changed the title |WIP] Division of AMPL code in functional blocks Division of AMPL code in functional blocks Jul 12, 2024
@p-arvy p-arvy requested review from So-Fras and klorel July 12, 2024 15:55
Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments!

open-reac/README.md Outdated Show resolved Hide resolved
open-reac/README.md Outdated Show resolved Hide resolved
Copy link

@p-arvy p-arvy requested a review from So-Fras July 22, 2024 09:42
@So-Fras So-Fras merged commit d97a0fd into main Jul 22, 2024
6 checks passed
@So-Fras So-Fras deleted the division-of-ampl-code branch July 22, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants