Add concise and detailed logs for shunt compensators activation #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tween reactive discretized and reactive optimal value is over a configured threshold. Signed-off-by: Franck LECUYER <[email protected]>
…n discrete and optimal value over the threshold. Signed-off-by: Franck LECUYER <[email protected]>
ayolab
approved these changes
May 29, 2024
So-Fras
changed the title
So-Fras
requested changes
Jun 5, 2024
...-reac/src/main/java/com/powsybl/openreac/parameters/output/network/NetworkModifications.java
Outdated
Show resolved
Hide resolved
.../main/java/com/powsybl/openreac/parameters/output/network/ShuntCompensatorNetworkOutput.java
Outdated
Show resolved
Hide resolved
.../main/java/com/powsybl/openreac/parameters/output/network/ShuntCompensatorNetworkOutput.java
Outdated
Show resolved
Hide resolved
.../main/java/com/powsybl/openreac/parameters/output/network/ShuntCompensatorNetworkOutput.java
Outdated
Show resolved
Hide resolved
So-Fras
reviewed
Jun 5, 2024
| LoadFlowResult loadFlowResult = LoadFlow.run(network); | ||
| assertTrue(loadFlowResult.isOk()); | ||
| assertTrue(loadFlowResult.isFullyConverged() || loadFlowResult.isPartiallyConverged()); |
There was a problem hiding this comment.
I saw that isOk() is deprecated. But is that function equivalent to isFullyConverged() || isPartiallyConverged()?
There was a problem hiding this comment.
Replaced by a call to isFullyConverged (same was previously done in powsybl-open-loadflow)
Signed-off-by: Franck LECUYER <[email protected]>
Signed-off-by: Franck LECUYER <[email protected]>
|
So-Fras
approved these changes
Jun 17, 2024
So-Fras
deleted the
log_differences_between_discretized_and_optimized_shunt_compensator_reactive_power_value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Feature
What is the current behavior?
No logs are generated for shunt compensators, when the delta between the discretized reactive value and the optimal reactive value given by the optimizer is too big, and thus can lead to further loadflow divergence problem.
What is the new behavior (if this is a feature change)?
Concise and detailed logs are now generated for shunt compensators activation, when the delta between the discretized reactive value and the optimal reactive value is over a configured threshold.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: