Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export buses voltage and update targets V #53

Merged
merged 31 commits into from
Feb 6, 2024
Merged

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Jan 10, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

The voltage (v/angle) of buses is not exported from AMPL. Voltage targets of regulating ShuntCompensators/RatioTapChangers are not updated.

What is the new behavior (if this is a feature change)?
The voltage are now exported and the voltage target are updated if ShuntCompensator/RatioTapChanger is regulating.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@p-arvy p-arvy self-assigned this Jan 10, 2024
@p-arvy p-arvy force-pushed the export_buses_voltage branch from 43ec463 to 023995c Compare January 17, 2024 17:20
Signed-off-by: parvy <[email protected]>
@p-arvy p-arvy changed the base branch from main to refactor_outputs January 17, 2024 17:31
@p-arvy p-arvy requested review from annetill and klorel January 17, 2024 17:31
@p-arvy p-arvy changed the title [WIP] Export buses voltage and update targets V Export buses voltage and update targets V Jan 17, 2024
@annetill annetill requested a review from So-Fras January 18, 2024 09:19
@p-arvy p-arvy changed the base branch from refactor_outputs to main January 18, 2024 09:37
@p-arvy p-arvy changed the title Export buses voltage and update targets V [WIP] Export buses voltage and update targets V Jan 25, 2024
@p-arvy p-arvy changed the title [WIP] Export buses voltage and update targets V Export buses voltage and update targets V Jan 31, 2024
@p-arvy p-arvy requested a review from annetill February 1, 2024 15:52
p-arvy and others added 2 commits February 1, 2024 17:16
Copy link

sonarqubecloud bot commented Feb 5, 2024

Copy link
Contributor

@klorel klorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMPL is fine :)

@So-Fras So-Fras merged commit 4701635 into main Feb 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants