-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export buses voltage and update targets V #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
p-arvy
force-pushed
the
export_buses_voltage
branch
from
January 17, 2024 17:20
43ec463
to
023995c
Compare
Signed-off-by: parvy <[email protected]>
p-arvy
changed the title
[WIP] Export buses voltage and update targets V
Export buses voltage and update targets V
Jan 17, 2024
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
annetill
reviewed
Jan 24, 2024
open-reac/src/main/java/com/powsybl/openreac/parameters/OpenReacAmplIOFiles.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Jan 24, 2024
open-reac/src/main/java/com/powsybl/openreac/parameters/output/OpenReacResult.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Jan 24, 2024
open-reac/src/main/java/com/powsybl/openreac/parameters/output/OpenReacResult.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Jan 24, 2024
open-reac/src/main/java/com/powsybl/openreac/parameters/output/OpenReacResult.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Jan 24, 2024
open-reac/src/main/java/com/powsybl/openreac/parameters/output/OpenReacResult.java
Outdated
Show resolved
Hide resolved
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
p-arvy
changed the title
Export buses voltage and update targets V
[WIP] Export buses voltage and update targets V
Jan 25, 2024
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
p-arvy
changed the title
[WIP] Export buses voltage and update targets V
Export buses voltage and update targets V
Jan 31, 2024
annetill
reviewed
Feb 1, 2024
open-reac/src/main/java/com/powsybl/openreac/parameters/output/OpenReacResult.java
Outdated
Show resolved
Hide resolved
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
Signed-off-by: parvy <[email protected]>
annetill
reviewed
Feb 1, 2024
open-reac/src/main/java/com/powsybl/openreac/parameters/output/OpenReacResult.java
Show resolved
Hide resolved
Signed-off-by: parvy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
klorel
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMPL is fine :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
The voltage (v/angle) of buses is not exported from AMPL. Voltage targets of regulating ShuntCompensators/RatioTapChangers are not updated.
What is the new behavior (if this is a feature change)?
The voltage are now exported and the voltage target are updated if ShuntCompensator/RatioTapChanger is regulating.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: