Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenReac parameters interface #43

Merged
merged 31 commits into from
Apr 18, 2024
Merged

Add OpenReac parameters interface #43

merged 31 commits into from
Apr 18, 2024

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Nov 16, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

#42

What kind of change does this PR introduce?

What is the current behavior?

Only the parameters listed in #42 are interfaced.

What is the new behavior (if this is a feature change)?
All OpenReac parameters are interfaced.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

p-arvy added 12 commits November 3, 2023 16:10
@p-arvy
Add two params to control consistency of voltage limits.
7c201cd 
Signed-off-by: parvy <[email protected]>
@p-arvy
Add interface for min/max voltage limit parameters.
34fbc8e 
Signed-off-by: parvy <[email protected]>
@p-arvy
Fix codesmell.
d440d7a 
Signed-off-by: parvy <[email protected]>
@p-arvy
Fix.
efdf25f 
Signed-off-by: parvy <[email protected]>
@p-arvy
Add unit test with comparison of input file exported.
72cacc1 
Signed-off-by: parvy <[email protected]>
@p-arvy
Refactor java code.
b5421e8 
Signed-off-by: parvy <[email protected]>
@p-arvy
Refactor ampl code.
3ce751b 
Signed-off-by: parvy <[email protected]>
@p-arvy
Refactor unit test.
1259368 
Signed-off-by: parvy <[email protected]>
@p-arvy
Add openreac parameters in OpenReacParameters.
0ac46c9 
Signed-off-by: parvy <[email protected]>
@p-arvy
Add methods to access/set OpenReac parameters.
dac3c18 
Signed-off-by: parvy <[email protected]>
@p-arvy
Remove algoParam map and replace with OpenReac interfaces.
7bd8d98 
Signed-off-by: parvy <[email protected]>
@p-arvy
Improve unit tests.
faebf3b 
Signed-off-by: parvy <[email protected]>
@p-arvy p-arvy added the Java label Nov 16, 2023
@p-arvy p-arvy requested a review from annetill November 16, 2023 18:28
@p-arvy
Add last OpenReac parameters in Java.
7819ec6 
Signed-off-by: parvy <[email protected]>
@p-arvy
Add methods and unit tests.
e4ee12c 
Signed-off-by: parvy <[email protected]>
@p-arvy
Add unit tests and default_param_algo.txt file to OpenReac resources.
1e00536 
Signed-off-by: parvy <[email protected]>
@p-arvy
Refactor.
28fe3f2 
Signed-off-by: parvy <[email protected]>
@p-arvy
Merge remote-tracking branch 'origin/main' into add_openreac_paramete…
d99d63d 
…rs_interface

# Conflicts:
#	open-reac/src/main/java/com/powsybl/openreac/parameters/input/OpenReacParameters.java
#	open-reac/src/test/java/com/powsybl/openreac/parameters/input/json/OpenReacJsonModuleTest.java
@p-arvy
Merge branch 'main' into add_openreac_parameters_interface
99c523f 
# Conflicts:
#	open-reac/src/main/java/com/powsybl/openreac/parameters/input/OpenReacParameters.java
#	open-reac/src/main/java/com/powsybl/openreac/parameters/input/json/OpenReacParametersDeserializer.java
#	open-reac/src/main/java/com/powsybl/openreac/parameters/input/json/OpenReacParametersSerializer.java
#	open-reac/src/test/java/com/powsybl/openreac/OpenReacParametersTest.java
#	open-reac/src/test/java/com/powsybl/openreac/OpenReacRunnerTest.java
#	open-reac/src/test/java/com/powsybl/openreac/parameters/input/json/OpenReacJsonModuleTest.java
#	open-reac/src/test/resources/expected_inputs/param_algo.txt
#	open-reac/src/test/resources/openreac-input-algo-parameters/default.txt
#	open-reac/src/test/resources/openreac-input-algo-parameters/modified_param_algo.txt
#	open-reac/src/test/resources/parameters.json
@p-arvy
Refactor TU.
54210a8 
Signed-off-by: parvy <[email protected]>
@p-arvy
Refactor.
e330673 
Signed-off-by: parvy <[email protected]>
@p-arvy
Refactor.
6747d37 
Signed-off-by: parvy <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@p-arvy p-arvy self-assigned this Jan 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@So-Fras So-Fras mentioned this pull request Feb 27, 2024
Merged
5 tasks
@p-arvy
add comments.
bc7158e 
Signed-off-by: parvy <[email protected]>
@p-arvy p-arvy changed the title [WIP] Add openreac parameters interface Add OpenReac parameters interface Apr 8, 2024
@p-arvy p-arvy requested a review from So-Fras April 8, 2024 15:48
@p-arvy
rename parameters.
78ca814 
Signed-off-by: parvy <[email protected]>
So-Fras
So-Fras requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments. Thanks for your work!

...src/main/java/com/powsybl/openreac/parameters/input/json/OpenReacParametersDeserializer.java Outdated Show resolved Hide resolved
open-reac/src/main/java/com/powsybl/openreac/parameters/input/OpenReacParameters.java Outdated Show resolved Hide resolved
p-arvy added 4 commits April 17, 2024 10:32
@p-arvy
Merge branch 'refs/heads/main' into add_openreac_parameters_interface
ca2cd9d 
# Conflicts:
#	open-reac/src/main/java/com/powsybl/openreac/parameters/input/OpenReacParameters.java
#	open-reac/src/main/java/com/powsybl/openreac/parameters/input/json/OpenReacParametersDeserializer.java
#	open-reac/src/main/java/com/powsybl/openreac/parameters/input/json/OpenReacParametersSerializer.java
#	open-reac/src/test/java/com/powsybl/openreac/OpenReacParametersTest.java
#	open-reac/src/test/java/com/powsybl/openreac/OpenReacRunnerTest.java
#	open-reac/src/test/java/com/powsybl/openreac/parameters/input/json/OpenReacJsonModuleTest.java
#	open-reac/src/test/resources/expected_inputs/param_algo.txt
#	open-reac/src/test/resources/openreac-input-algo-parameters/default.txt
#	open-reac/src/test/resources/openreac-input-algo-parameters/modified_param_algo.txt
#	open-reac/src/test/resources/parameters.json
@p-arvy
Update merge.
d94cd78 
Signed-off-by: parvy <[email protected]>
@p-arvy
Revert modifications on ParamAlgoDeserializer.
599e59d 
Signed-off-by: parvy <[email protected]>
@p-arvy
Refactor json tests to fix code smell.
b49014d 
Signed-off-by: parvy <[email protected]>
@p-arvy p-arvy requested a review from So-Fras April 17, 2024 09:50
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@So-Fras So-Fras merged commit 6fd3cc9 into main Apr 18, 2024
6 checks passed
@So-Fras So-Fras deleted the add_openreac_parameters_interface branch April 18, 2024 10:46
@p-arvy p-arvy mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@So-Fras So-Fras So-Fras approved these changes

@annetill annetill Awaiting requested review from annetill

Assignees

@p-arvy p-arvy

Labels
Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-arvy @So-Fras