-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge content of preventive stop criterion into type, no impact on te… #1141
Open
pjeanmarie
wants to merge
1
commit into
rao_parameters_separate_unit_from_objective_function_type
Choose a base branch
from
rao_parameters_merge_type_and_preventive_stop_criterion
base: rao_parameters_separate_unit_from_objective_function_type
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjeanmarie
changed the title
Merge content of preventive stop criterion into type, no impact on te…
[WIP] Merge content of preventive stop criterion into type, no impact on te…
Sep 18, 2024
pjeanmarie
force-pushed
the
rao_parameters_use_unit_from_is_dc
branch
from
September 23, 2024 08:09
affc299
to
2924276
Compare
pjeanmarie
force-pushed
the
rao_parameters_merge_type_and_preventive_stop_criterion
branch
from
September 23, 2024 08:12
925df6e
to
27fdbce
Compare
pjeanmarie
force-pushed
the
rao_parameters_use_unit_from_is_dc
branch
from
September 23, 2024 12:31
2924276
to
5ce3d76
Compare
pjeanmarie
force-pushed
the
rao_parameters_merge_type_and_preventive_stop_criterion
branch
from
September 24, 2024 08:14
27fdbce
to
fae79bc
Compare
pjeanmarie
force-pushed
the
rao_parameters_use_unit_from_is_dc
branch
from
September 24, 2024 09:10
5ce3d76
to
1706a08
Compare
pjeanmarie
force-pushed
the
rao_parameters_merge_type_and_preventive_stop_criterion
branch
from
September 24, 2024 09:11
fae79bc
to
fe7230c
Compare
pjeanmarie
force-pushed
the
rao_parameters_use_unit_from_is_dc
branch
from
October 1, 2024 15:31
1706a08
to
7f7e969
Compare
pjeanmarie
force-pushed
the
rao_parameters_merge_type_and_preventive_stop_criterion
branch
from
October 2, 2024 08:49
fe7230c
to
fd71fe6
Compare
pjeanmarie
force-pushed
the
rao_parameters_use_unit_from_is_dc
branch
from
October 2, 2024 14:23
7f7e969
to
b65e806
Compare
pjeanmarie
force-pushed
the
rao_parameters_merge_type_and_preventive_stop_criterion
branch
2 times, most recently
from
October 2, 2024 14:48
46212b0
to
dfd6477
Compare
pjeanmarie
force-pushed
the
rao_parameters_use_unit_from_is_dc
branch
from
October 8, 2024 09:31
b65e806
to
54aa50a
Compare
pjeanmarie
force-pushed
the
rao_parameters_merge_type_and_preventive_stop_criterion
branch
from
October 8, 2024 14:22
dfd6477
to
ba19da2
Compare
pjeanmarie
force-pushed
the
rao_parameters_use_unit_from_is_dc
branch
from
October 28, 2024 15:03
54aa50a
to
802f70b
Compare
pjeanmarie
force-pushed
the
rao_parameters_merge_type_and_preventive_stop_criterion
branch
from
October 28, 2024 15:30
ba19da2
to
8810fed
Compare
pjeanmarie
changed the title
[WIP] Merge content of preventive stop criterion into type, no impact on te…
Merge content of preventive stop criterion into type, no impact on te…
Oct 28, 2024
pjeanmarie
added
breaking-change
Changes could break users' code
PR : dont-merge-before-other
PR mustn't be merged before another (referenced in the description or in the comments)
labels
Nov 5, 2024
pjeanmarie
force-pushed
the
rao_parameters_merge_type_and_preventive_stop_criterion
branch
from
November 19, 2024 11:20
8810fed
to
4e59f6b
Compare
pjeanmarie
changed the base branch from
rao_parameters_use_unit_from_is_dc
to
rao_parameters_separate_unit_from_objective_function_type
November 19, 2024 11:21
obrix
approved these changes
Nov 26, 2024
obrix
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DCO needs to be fixed
pjeanmarie
force-pushed
the
rao_parameters_separate_unit_from_objective_function_type
branch
from
November 29, 2024 09:09
8cadd8c
to
02f55a5
Compare
pjeanmarie
force-pushed
the
rao_parameters_merge_type_and_preventive_stop_criterion
branch
from
November 29, 2024 09:12
4e59f6b
to
68f03a1
Compare
pjeanmarie
force-pushed
the
rao_parameters_separate_unit_from_objective_function_type
branch
from
November 29, 2024 10:18
02f55a5
to
c85394f
Compare
pjeanmarie
force-pushed
the
rao_parameters_merge_type_and_preventive_stop_criterion
branch
from
November 29, 2024 10:19
68f03a1
to
448cd9e
Compare
pjeanmarie
force-pushed
the
rao_parameters_separate_unit_from_objective_function_type
branch
from
December 9, 2024 10:37
c85394f
to
d588d48
Compare
Signed-off-by: Pauline Jean-Marie <[email protected]>
pjeanmarie
force-pushed
the
rao_parameters_merge_type_and_preventive_stop_criterion
branch
from
December 9, 2024 10:48
448cd9e
to
f3fd6b2
Compare
phiedw
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Changes could break users' code
PR : dont-merge-before-other
PR mustn't be merged before another (referenced in the description or in the comments)
PR: waiting-for-review
This PR is waiting to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sts results expected
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#1084
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: