Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default imax values when importing curative cnec #1096

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

danielthirion
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@danielthirion danielthirion force-pushed the set_default_imax_when_importing_curative_cnecs branch from f1b8423 to 006b0e7 Compare July 22, 2024 13:56
Signed-off-by: thiriondan <[email protected]>
@danielthirion danielthirion force-pushed the set_default_imax_when_importing_curative_cnecs branch from 0e04faa to 0b74397 Compare July 22, 2024 14:05
}

private TImax findTargetImaxAfterSPS(final TBranch tBranch) {
return tBranch.getImaxAfterSPS() != null ? tBranch.getImaxAfterSPS() : tBranch.getImaxAfterOutage();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is required by the business requirements. However, I'm not convinced that it is a good idea, since the CSE CC process does not have any SPS. It would only duplicate the CNECs in outage instant to auto instant, with no effect on the RAO.
What do you think @phiedw ?

…openrao/data/craccreation/creator/cse/criticalbranch/CriticalBranchReader.java

Co-authored-by: Peter Mitri <[email protected]>
Signed-off-by: danielthirion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants