[WIP INTERNSHIP] Add constraints correctly on multi TimeSteps for PST #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
…steps Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
phiedw
requested changes
Aug 16, 2024
data/crac/crac-impl/src/main/java/com/powsybl/openrao/data/cracimpl/StandardRangeImpl.java
Show resolved
Hide resolved
| @@ -0,0 +1,350 @@ | |||
| ///* | |||
There was a problem hiding this comment.
you can make a new branch with this new class (or uncomment it if you think it makes sense to add it in this pr)
...va/com/powsybl/openrao/searchtreerao/linearoptimisation/algorithms/BestTapFinderMultiTS.java
Show resolved
Hide resolved
| @@ -112,6 +111,30 @@ public static LinearOptimizationResult optimize(IteratingLinearOptimizerMultiTSI | |||
| return bestResult; | |||
| } | |||
|
|
|||
| // Add logs for this class: RaoRunner not called in order to use MIP for multi TS so logs are missing | |||
| private static void logMostLimitedElementsBetweenIteration(IteratingLinearOptimizerMultiTSInput input, IteratingLinearOptimizerParameters parameters, OpenRaoLogger logger, IteratingLinearOptimizationResultImpl result) { | |||
There was a problem hiding this comment.
does this method log the margin for all cnecs?
...m/powsybl/openrao/searchtreerao/linearoptimisation/algorithms/fillers/CoreProblemFiller.java
Outdated
Show resolved
Hide resolved
| return solver.makeConstraint(lb, ub, signedRangeActionVariationConstraintId(rangeAction, state)); | ||
| } | ||
|
|
||
| public OpenRaoMPConstraint addInjectionBalanceVariationConstraint(double lb, double ub, State state) { |
There was a problem hiding this comment.
maybe we can add an extra argument for the timestep so we can get the constraint at a later time
...bl/openrao/searchtreerao/linearoptimisation/inputs/IteratingLinearOptimizerMultiTSInput.java
Outdated
Show resolved
Hide resolved
...arch-tree-rao/src/main/java/com/powsybl/openrao/searchtreerao/timestepsrao/TimeStepsRao.java
Outdated
Show resolved
Hide resolved
...arch-tree-rao/src/main/java/com/powsybl/openrao/searchtreerao/timestepsrao/TimeStepsRao.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,270 @@ | |||
| package com.powsybl.openrao.searchtreerao.linearoptimisation.algorithms.linearproblem; | |||
There was a problem hiding this comment.
please add author and header
There was a problem hiding this comment.
and rename the file/class to XXXTest
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Signed-off-by: wangjer <[email protected]>
Godelaine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: