resolve some comments

Signed-off-by: Thomas Bouquet <[email protected]>
powsybl · Nov 7, 2024 · 6bf2981 · 6bf2981
1 parent 4327b93
commit 6bf2981
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/...l/openrao/data/cracio/csaprofiles/craccreator/remedialaction/ElementaryActionsHelper.java b/...l/openrao/data/cracio/csaprofiles/craccreator/remedialaction/ElementaryActionsHelper.java
@@ -50,6 +50,7 @@ public class ElementaryActionsHelper {
     private final Map<String, Set<TapPositionAction>> nativeTapPositionActionsPerNativeRemedialActionAuto;
     private final Map<String, Set<StaticPropertyRange>> nativeStaticPropertyRangesPerNativeGridStateAlteration;
     final Map<String, Set<ContingencyWithRemedialAction>> nativeContingencyWithRemedialActionPerNativeRemedialAction;
+    private static final String SIPS = "RemedialActionSchemeKind.sips";
 
     public ElementaryActionsHelper(CsaProfileCrac nativeCrac) {
         this.nativeRemedialActionGroups = nativeCrac.getNativeObjects(RemedialActionGroup.class);
@@ -141,7 +142,7 @@ private String getAssociatedRemedialActionScheme(String remedialActionId) {
         }
 
         RemedialActionScheme nativeRemedialActionScheme = linkedRemedialActionSchemePropertyBags.get(0);
-        if (!"RemedialActionSchemeKind.sips".equals(nativeRemedialActionScheme.kind())) {
+        if (!SIPS.equals(nativeRemedialActionScheme.kind())) {
             throw new OpenRaoImportException(ImportStatus.INCONSISTENCY_IN_DATA, String.format("Remedial action %s will not be imported because of an unsupported kind for remedial action schedule (only SIPS allowed)", remedialActionId));
         }
         if (Boolean.FALSE.equals(nativeRemedialActionScheme.normalArmed())) {

diff --git a/...les/src/main/java/com/powsybl/openrao/data/cracio/csaprofiles/nc/GridStateAlteration.java b/...les/src/main/java/com/powsybl/openrao/data/cracio/csaprofiles/nc/GridStateAlteration.java
@@ -1,5 +1,15 @@
+/*
+ * Copyright (c) 2024, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
 package com.powsybl.openrao.data.cracio.csaprofiles.nc;
 
+/**
+ * @author Thomas Bouquet {@literal <thomas.bouquet at rte-france.com>}
+ */
 public interface GridStateAlteration extends NCObject {
     String propertyReference();