Fix PTC action support and support of RTC action #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
annetill
reviewed
Oct 4, 2023
src/main/java/com/powsybl/openloadflow/ac/AcloadFlowEngine.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
annetill
reviewed
Oct 12, 2023
| @@ -523,15 +524,15 @@ public static <T> List<LfNetwork> load(T network, LfNetworkLoader<T> networkLoad | |||
| return load(network, networkLoader, parameters, Reporter.NO_OP); | |||
| } | |||
|
|
|||
| public static <T> List<LfNetwork> load(T network, LfNetworkLoader<T> networkLoader, SlackBusSelector slackBusSelector, Reporter reporter) { | |||
There was a problem hiding this comment.
This removal is okay for me, to be confirmed by @geofjamg
Signed-off-by: Anne Tilloy <[email protected]>
annetill
reviewed
Oct 12, 2023
src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisWithActionsTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
annetill
approved these changes
Oct 12, 2023
Signed-off-by: Anne Tilloy <[email protected]>
annetill
changed the title
Signed-off-by: Anne Tilloy <[email protected]>
geofjamg
requested changes
Oct 13, 2023
src/main/java/com/powsybl/openloadflow/network/LfNetworkLoader.java
Outdated
Show resolved
Hide resolved
| @@ -22,6 +22,10 @@ public class LfTopoConfig { | |||
|
|
|||
| private final Set<String> busIdsToLose = new HashSet<>(); | |||
|
|
|||
| private final Set<String> branchIdsWithPtcToRetain = new HashSet<>(); | |||
There was a problem hiding this comment.
For later, but maybe we should find a better name for LfTopoConfig once this will be added?
There was a problem hiding this comment.
We can do it now, shunt compensator action is coming just after, what do you suggest ?
There was a problem hiding this comment.
Could be a LfNetworkLoadingParameters
There was a problem hiding this comment.
I think we can leave it like this and re-think about it with shunt compensator action.
src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
jeandemanged
approved these changes
Oct 13, 2023
|
Kudos, SonarCloud Quality Gate passed! |
geofjamg
approved these changes
Oct 17, 2023
geofjamg
pushed a commit
that referenced
this pull request
Oct 17, 2023
Signed-off-by: Hadrien <[email protected]> Co-authored-by: Anne Tilloy <[email protected]> Co-authored-by: Damien Jeandemange <[email protected]>
geofjamg
pushed a commit
that referenced
this pull request
Oct 17, 2023
Signed-off-by: Hadrien <[email protected]> Co-authored-by: Anne Tilloy <[email protected]> Co-authored-by: Damien Jeandemange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
Currently, PTC and RTC PI model does not include tap positions if regulation is deactivated. This is an issue if the PST or RTC is involved in operator strategies / actions.
What is the new behavior (if this is a feature change)?
This PR allows PTC and RTC to be retained also when they are involved in operator strategies / actions.
With this PR, PTC and RTC pimodel contains tap positions if the PTC and RTC is involved not only in regulation but also in at least one action in a security analysis run.
Does this PR introduce a breaking change or deprecate an API?
No
Other information:
none