Add method for updating flows in NAD viewer #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: massimo.ferraro <[email protected]>
Signed-off-by: massimo.ferraro <[email protected]>
flo-dup
requested changes
Dec 12, 2024
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
reviewed
Dec 12, 2024
demo/src/diagram-viewers/data/nad-eurostag-tutorial-example1.svg
Outdated
Show resolved
Hide resolved
…d add caching map Signed-off-by: massimo.ferraro <[email protected]>
Signed-off-by: massimo.ferraro <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
requested changes
Jan 8, 2025
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: massimo.ferraro <[email protected]>
Signed-off-by: massimo.ferraro <[email protected]>
flo-dup
requested changes
Jan 9, 2025
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: massimo.ferraro <[email protected]>
|
flo-dup
approved these changes
Jan 9, 2025
jonenst
reviewed
Jan 14, 2025
| @@ -208,7 +268,7 @@ export const addNadToDemo = () => { | |||
| handleTextNodeMove, | |||
| handleNodeSelect, | |||
| true, | |||
| true, | |||
| false, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the current behavior?
The NAD viewer does not allow to change the flows shown in the SVG
What is the new behavior (if this is a feature change)?
The NAD viewer provide a method for changing the flows shown in the SVG
Does this PR introduce a breaking change or deprecate an API?
Other information:
In the demo, in the add-diagram.ts file, examples of code changing flows are provided