Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node breaker disconnect #348

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Fix node breaker disconnect #348

wants to merge 7 commits into from

Conversation

flo-dup
Copy link

@flo-dup flo-dup commented Oct 16, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

  • Disconnect may open non-related breakers
  • Disconnect may return true when not disconnected
  • Map node to aggregate node is duplicated

What is the new behavior (if this is a feature change)?

  • Disconnect does not open non-related breakers
  • Disconnect does return true only if disconnect successful
  • Reusing the node to aggregate node map of ConnectivityInspector

Does this PR introduce a breaking change or deprecate an API?

No

Signed-off-by: Florian Dupuy <[email protected]>
@flo-dup flo-dup requested a review from geofjamg October 16, 2023 14:34
@flo-dup
Copy link
Author

flo-dup commented Oct 16, 2023

          L                        LA
          |                         |
       ---1---                      4
       |     |                      |
      BR1   BR2                    BR4
       |     |                      |
       ---0---   -----BR3-----   ---3---
        BBS1                      BBS2

When disconnecting load L, the minimal cut is looked for all the bbs, including BBS2. The minimal cut for L - BBS2 is BR3, hence BR3 is opened when disconnecting L, whereas it is not needed.

@flo-dup
Copy link
Author

flo-dup commented Oct 16, 2023

    L1                   L2
     |                    |
     1                    3
     |                    |
    D1                   D2
     |                    |
  ---0---  ----BR----  ---2---
    BBS1                BBS2

Similar case, with a load which cannot be disconnected because of disconnector D1. But disconnecting terminal of load L1 returns true, as BR is opened. Nonetheless it should return false and BR should remain open.

@flo-dup
Copy link
Author

flo-dup commented Oct 17, 2023

Other unit test which fails when disconnecting load. Switch BR1 is opened, load remains linked with line and 2wt.

     Load        Line    2WT
       |          |       |
   ----2---       3       4
   |      |       |       |
  BR2    BR3     BR4     BR5
   |      |       |       |
   -----------1------------
              |
             BR1
              |
   -----------0------------
            BBS1

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.0% 96.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant