GetConnectables performance optimization #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or messages Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Adds equipment information on problematic VSC and Busbar index
* Remove deprecated checkActivePowerLimits call (fixup from powsybl 4.7 migration) * StaticVarCompensatorAdder use setpoint instead of deprecated setPoint * remove deprecated Identifiable getName Signed-off-by: HARPER Jon <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
SlimaneAmar
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Performance optimization
What is the current behavior?
Network.getConnectables is very slow because whatever the connectable class we pass, we need to get all identifiables of the network and then filter.
What is the new behavior (if this is a feature change)?
Network.getConnectables only query the kind of equipment we need.
Does this PR introduce a breaking change or deprecate an API?
Other information: