Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Substation preloading #273

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[WIP] Substation preloading #273

wants to merge 12 commits into from

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Aug 9, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg geofjamg changed the title Substation preloading [WIP] Substation preloading Aug 9, 2022
# Conflicts:
#	network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreRepository.java
#	network-store-server/src/main/java/com/powsybl/network/store/server/QueryCatalog.java
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

91.2% 91.2% Coverage
0.0% 0.0% Duplication

# Conflicts:
#	network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreRepository.java
#	network-store-server/src/main/java/com/powsybl/network/store/server/QueryCatalog.java
#	network-store-server/src/main/java/com/powsybl/network/store/server/TableMapping.java
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

78.1% 78.1% Coverage
0.0% 0.0% Duplication

@jonenst
Copy link
Collaborator

jonenst commented Oct 21, 2024

Substation or Voltage level ?

substations is more versatile, it should not be too much overhead for people needing only the voltagelevel, but cuts the number of requests from maybe 3-5 to 1 for people needed the whole substation (e.g. single line diagram substation). Or we can do both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants